[release-1.19] Skip disabling keep-alives when shutting down the webhook server#3306
Conversation
My theory is that when this happens the go runtime will close idle connections. If by chance the API server is making a request and re-using a connection (that is closing) it will receive an io.EOF. Thus introducing a flake. So we now remove this setting change and let all the connections close during the regular graceful shutdown. We would have already lame ducked so the webhook shouldn't be receiving new requests.
knative-prow
bot
added
the
size/XS
|
/lgtm 1.19 is EOL in 3rd week of Jan but if there's any patch release we need out since then it may be worth pulling this change in |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, knative-prow-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.19 #3306 +/- ##
================================================
- Coverage 74.61% 74.44% -0.17%
================================================
Files 209 209
Lines 12030 9631 -2399
================================================
- Hits 8976 7170 -1806
+ Misses 2775 2181 -594
- Partials 279 280 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
This is an automated cherry-pick of #3295