Skip to content

[release-1.19] Fix Serving Metric Names to match Design Document #16292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow merged 1 commit into from
Dec 16, 2025
Merged

[release-1.19] Fix Serving Metric Names to match Design Document #16292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/queue/request_metric.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func NewAppRequestMetricsHandler(
)

handler.duration, err = meter.Float64Histogram(
"kn.queueproxy.app.duration",
"kn.serving.invocation.duration",
metric.WithDescription("The duration of task execution"),
metric.WithUnit("s"),
metric.WithExplicitBucketBoundaries(latencyBounds...),
Expand All @@ -69,7 +69,7 @@ func NewAppRequestMetricsHandler(
}

handler.queueLen, err = meter.Int64Gauge(
"kn.queueproxy.depth",
"kn.serving.queue.depth",
metric.WithDescription("Number of current requests in the queue"),
metric.WithUnit("{request}"),
)
Expand Down
4 changes: 2 additions & 2 deletions pkg/queue/request_metric_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ func assertMetrics(t *testing.T, reader *metric.ManualReader, status int) {
metricstest.MetricsEqual(
scopeName,
metricdata.Metrics{
Name: "kn.queueproxy.depth",
Name: "kn.serving.queue.depth",
Unit: "{request}",
Description: "Number of current requests in the queue",
Data: metricdata.Gauge[int64]{
Expand All @@ -125,7 +125,7 @@ func assertMetrics(t *testing.T, reader *metric.ManualReader, status int) {
},
},
metricdata.Metrics{
Name: "kn.queueproxy.app.duration",
Name: "kn.serving.invocation.duration",
Unit: "s",
Description: "The duration of task execution",
Data: metricdata.Histogram[float64]{
Expand Down
Loading