If request.body is a file-like object, send fails

[MerlijnWajer]

When using the python requests library, if one sets the body (data) to a file-like object, such as io.BytesIO or io.StringIO, the body becomes something like <_io.BytesIO object at 0x1550d50> when using pyodide-http, as opposed to the actual contents of the file-like object.

Below is a very hacky fix for this problem:

diff --git a/pyodide_http/_core.py b/pyodide_http/_core.py
index 1cb711d..e8de6b9 100644
--- a/pyodide_http/_core.py
+++ b/pyodide_http/_core.py
@@ -118,7 +118,13 @@ def send(request: Request, stream: bool = False) -> Response:
         if name.lower() not in HEADERS_TO_IGNORE:
             xhr.setRequestHeader(name, value)

-    xhr.send(to_js(request.body))
+    body = request.body
+
+    if hasattr(body, 'read'):
+        body = body.read()
+
+    xhr.send(to_js(body))
+    #xhr.send(to_js(request.body))

     headers = dict(Parser().parsestr(xhr.getAllResponseHeaders()))

I suppose that perhaps a stream method could be used with a file-like object? Any ideas on how to best solve this problem?

[MerlijnWajer]

(I ran into this when using the internetarchive library - as discussed here jjjake/internetarchive#550)

Otherwise the library mostly seems to work, so that's great.

[MerlijnWajer]

@koenvo - do you have any opinion on what is the right fix for this?

[koenvo]

@koenvo - do you have any opinion on what is the right fix for this?

Hi! Sorry for the late reply.

As your solution follows the behavior of requests (because it works), it looks like a good solution for now.

When people like to do streaming uploads another solution is required. But at this moment there doesn’t seem to be a blocking streaming solution possible. XMLHttpRequest can’t do streaming upload and fetch isn’t blocking.

Are you able and willing to create a PR for this?

[MerlijnWajer]

Sure thing, I'll do that today, thanks for the reply.

[koenvo]

hi @MerlijnWajer, do you need any help with this?

[MerlijnWajer]

Just made the pull request, sorry for the extreme delay, I was very busy.