Skip to content

Unify controlnet parameters name and change scripts name.#1821

Merged
kohya-ss merged 40 commits intokohya-ss:sd3from
sdbds:sd3
Dec 7, 2024
Merged

Unify controlnet parameters name and change scripts name.#1821
kohya-ss merged 40 commits intokohya-ss:sd3from
sdbds:sd3

Conversation

@sdbds
Copy link
Copy Markdown
Contributor

@sdbds sdbds commented Dec 4, 2024

Multiple versions of the controlnet training script use three different parameter names, so the parameters are unified.
--controlnet_model_path
--controlnet_model_name_or_path
As well as renaming the initial version of the controlnet script to train_control_net.py

sdbds added 30 commits June 26, 2024 19:25
@kohya-ss
Copy link
Copy Markdown
Owner

kohya-ss commented Dec 4, 2024

Thank you for this! This makes sense.

However, it seems that this will be a breaking change when it is merged into the main branch in the future. I think breaking changes are allowed on the dev/sd3 branch. Therefore, although the name is not good, I think it is better to use controlnet_model_name_or_path used in train_controlnet.py.

@sdbds
Copy link
Copy Markdown
Contributor Author

sdbds commented Dec 4, 2024

Thank you for this! This makes sense.

However, it seems that this will be a breaking change when it is merged into the main branch in the future. I think breaking changes are allowed on the dev/sd3 branch. Therefore, although the name is not good, I think it is better to use controlnet_model_name_or_path used in train_controlnet.py.

OK, I'll use controlnet_model_name_or_path.

@kohya-ss kohya-ss merged commit abff4b0 into kohya-ss:sd3 Dec 7, 2024
@kohya-ss
Copy link
Copy Markdown
Owner

kohya-ss commented Dec 7, 2024

Thank you for updating!

I have added a script train_controlnet.py for backwards compatibility and displays a deprecation warning. It doesn't work on sd3 branch though, I should update the script before merging sd3 branch to main.

nana0304 pushed a commit to nana0304/sd-scripts that referenced this pull request Jun 4, 2025
)

* Update sd3_train.py

* add freeze block lr

* Update train_util.py

* update

* Revert "add freeze block lr"

This reverts commit 8b16535.

# Conflicts:
#	library/train_util.py
#	sd3_train.py

* use same control net model path

* use controlnet_model_name_or_path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants