Fixes macos build for kokkos/pykokkos#313

[kennykos]

See kokkos/pykokkos#313 for issue.

[IvanGrigorik]

@kennykos
What about previous macOS versions?
Should you still modify MACOSX_RPATH like it was done before, or not?

[gliga]

Could you explain the reason this works.
If it works, I am fine to merge.

[kennykos]

@gliga @IvanGrigorik

To address your concerns, my latest commit adds back in MACOSX_RPATH for backwards compatibility and directly translates the UNIX INSTALL_RPATH to macos lingo (as per https://docs.conda.io/projects/conda-build/en/stable/resources/use-shared-libraries.html, $ORIGIN is evq with @loader_path)

[JBludau]

What does the CMake documentation say on this?

[IvanGrigorik]

@kennykos can you try to override just INSTALL_RPATH? It looks like that should work as well

[kennykos]

@kennykos can you try to override just INSTALL_RPATH? It looks like that should work as well

Removing MACOSX_RPATH worked on my local machine, I just pushed the code!

[kennykos]

What does the CMake documentation say on this?

Here is the CMake documentation for INSTALL_RPATH, but it's a little unclear. The conda documentation stateing the equivalence of $ORIGIN and @loader_path is what I used to motivate this change.

[JBludau]

why are we not using what is recommended for apple platforms?
https://cmake.org/cmake/help/v4.2/prop_tgt/INSTALL_NAME_DIR.html#prop_tgt:INSTALL_NAME_DIR

[kennykos]

why are we not using what is recommended for apple platforms? https://cmake.org/cmake/help/v4.2/prop_tgt/INSTALL_NAME_DIR.html#prop_tgt:INSTALL_NAME_DIR

This worked on my local install, my last commit pushed the change.