This repository was archived by the owner on Dec 19, 2025. It is now read-only.
update README, highlight deprecated installation method#84
Merged
IvanGrigorik merged 6 commits intomainfrom Nov 25, 2025
Merged
update README, highlight deprecated installation method#84IvanGrigorik merged 6 commits intomainfrom
IvanGrigorik merged 6 commits intomainfrom
Conversation
IvanGrigorik
force-pushed
the
grigorik/install-upd
branch
from
964e272 to
a77f70d
Compare
IvanGrigorik
force-pushed
the
grigorik/install-upd
branch
from
a77f70d to
61edfdc
Compare
|
Remove the deprecated format then I can review |
JBludau
approved these changes
Nov 25, 2025
Comment on lines
-84
to
-89
| - Does `external/kokkos/CMakeLists.txt` exists? | ||
| - **YES**: assumes the submodule is already checked out | ||
| - > _If compute node does not have internet access, checkout submodule before installing!_ | ||
| - **NO**: does `.gitmodules` exist? | ||
| - **YES**: `git submodule update --init external/kokkos` | ||
| - **NO**: `git clone -b master https://github.com/kokkos/kokkos.git external/kokkos` |
Contributor
There was a problem hiding this comment.
oh, we forgot that earlier
kennykos
pushed a commit
to kennykos/pykokkos
that referenced
this pull request
Nov 25, 2025
Bring pykokkos install instructions up to date with kokkos/pykokkos-base#84
IvanGrigorik
added a commit
to kokkos/pykokkos
that referenced
this pull request
Dec 19, 2025
* Update install instructions Bring pykokkos install instructions up to date with kokkos/pykokkos-base#84 * Apply suggestion from @kennykos correct grammar for install instructions * update install instructions --------- Co-authored-by: KennyKos <{ID}+{username}@users.noreply.github.com> Co-authored-by: Ivan Grigorik <givan502@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on most recent
setuptoolsdocs, we should not call setup likepython setup.py ...Instead, we should do the following:
(verbose is optional)
In this PR, I suggest removing
python-build, since it uses deprecated installation methods.I also updated the README file and removed deprecated installation methods from it.
This PR also closes this sub-issue: #69 (comment)