This repository was archived by the owner on Dec 15, 2020. It is now read-only.
Authentication, authorization and user management#10
Merged
zwass merged 1 commit intokolide:masterfrom Aug 1, 2016
marpaia:authnz
Merged
Authentication, authorization and user management#10zwass merged 1 commit intokolide:masterfrom marpaia:authnz
zwass merged 1 commit intokolide:masterfrom
marpaia:authnz
Conversation
users.go
Outdated
| NeedsPasswordReset: needsPasswordReset, | ||
| } | ||
|
|
||
| return user, db.Create(&user).Error |
Contributor
There was a problem hiding this comment.
Maybe we should check the error and then return nil for *User if there was an error?
Contributor
|
Do we need a mechanism for expiring sessions (besides timeout which is implemented here)? |
| c.JSON(200, nil) | ||
| } | ||
|
|
||
| const ( |
Contributor
There was a problem hiding this comment.
As discussed, let's look into this random generation.
"Let's unfuck this"
kyleknighted
referenced
this pull request
in kyleknighted/kolide
Dec 20, 2016
Beginning to style up Pack Query table and new sidebar form
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress implementation of authentication, authorization and user management APIs.
TODO
[ ] Password reset endpoint (POST /api/v1/kolide/user/password/reset)needs_resetfield to user struct[ ] Integrateneeds_resetinto user management endpointuser.Enabledinto authorization checks[ ] Implement MySQL backing store with newsessionstable[ ] Add admin APIs for managing the sessions in the database[ ] Delete all sessions for a user (DELETE /api/v1/kolide/user/session)[ ] Delete a single session for a user (DELETE /api/v1/kolide/user/session/{id})[ ] Go through cookie settings and set modern security flags[ ] Write integration tests for the full login and user management flow[ ] Write a benchmark forJWTRenewalMiddleware[ ] Write tests forJWTRenewalMiddleware[ ] Write deeper tests forSessionMiddlewarethat stress the failure to set a session and callingGetSessionafter that[ ] See if there's a better way to castclaims['user_id']into a uint other than type asserting it as a float64 first