Merged
Conversation
… to include hash and optional icon data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new osquery table for Windows called
kolide_program_icon_checksums, which provides checksums for program icons without including the icon data itself. The implementation refactors existing code to support this new functionality and improves the flexibility of icon data collection.Closes #2401
New Table Addition:
kolide_program_icon_checksumstable to the platform-specific tables for Windows, allowing users to query program icon hashes alongside program names and versions, but without the icon image data. [1] [2]Refactoring for Data Collection:
generateUninstallerProgramIconsandgenerateInstallersProgramIcons) to accept anincludeIconparameter, enabling reuse of logic for both tables and controlling whether icon image data is included in the results. [1] [2] [3] [4]Implementation Details:
"icon"field in the result map based on theincludeIconparameter, ensuring the correct schema for each table. [1] [2]generateProgramIconChecksumsfunction to aggregate program icon hashes for the new table, leveraging the refactored icon generation functions withincludeIconset tofalse.These changes improve the flexibility and maintainability of the program icon tables, allowing for both detailed icon data and lightweight checksum queries.