chore(e2e): set threshold to 0, removed e2eWhenStable util (#DS-4616)#1294
Conversation
|
Visit the preview URL for this PR (updated for commit 07d436b): https://koobiq-next--prs-1294-cl42z2q8.web.app (expires Mon, 26 Jan 2026 09:43:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
🚨 E2E tests failedReview the report for details. 💡 Comment |
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
🚨 E2E tests failedReview the report for details. 💡 Comment |
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
🚨 E2E tests failedReview the report for details. 💡 Comment |
lskramarov
changed the title
artembelik
force-pushed
the
chore/playwright-threshold
branch
from
3948b9e to
4d68bc4
Compare
🚨 E2E tests failedReview the report for details. 💡 Comment |
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
✅ Snapshots updated! |
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
|
@artembelik с табами не удалось разобраться ? там похоже стабильно только со второго раза проходит: 
|
да, метод e2eWhenStable не работает upd. создал задачу по доработке DS-4627 |
artembelik
changed the title
artembelik
changed the title
There was a problem hiding this comment.
Pull request overview
This PR adjusts e2e screenshot testing configuration by setting the threshold to 0 for stricter visual regression testing. The change removes the e2eWhenStable utility function that was previously used to wait for element stability, and removes inline threshold overrides from individual test files.
Changes:
- Set Playwright screenshot comparison threshold to 0 (from 0.2) for exact pixel matching
- Removed
e2eWhenStableutility function and all its usages across e2e test files - Updated screenshot baseline images to reflect the new threshold
- Marked some tests as fixme (tabs and breadcrumbs) pending fixes
Reviewed changes
Copilot reviewed 7 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| playwright.config.ts | Changed screenshot threshold from 0.2 to 0 for stricter comparison |
| packages/e2e/utils/when-stable.ts | Deleted utility function file |
| packages/e2e/utils/index.ts | Removed export of when-stable utility |
| packages/components/tooltip/e2e.playwright-spec.ts | Removed inline threshold overrides |
| packages/components/popover/e2e.playwright-spec.ts | Removed inline threshold overrides |
| packages/components/tabs/e2e.playwright-spec.ts | Removed e2eWhenStable import/usage, marked tests as fixme |
| packages/components/breadcrumbs/e2e.playwright-spec.ts | Removed e2eWhenStable import/usage, marked tests as fixme |
| packages/components/toggle/screenshots/* | Updated screenshot baselines (binary files) |
| packages/components/icon/screenshots/* | Updated screenshot baselines (binary files) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.