Skip to content

chore(e2e): resolved flaky tabs test (#DS-4627)#1348

Merged
artembelik merged 3 commits into
mainfrom
fix/DS-4627
Feb 5, 2026
Merged

chore(e2e): resolved flaky tabs test (#DS-4627)#1348
artembelik merged 3 commits into
mainfrom
fix/DS-4627

Conversation

@artembelik

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings February 3, 2026 12:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR resolves a flaky end-to-end test for the tabs component by implementing a workaround that ensures proper rendering of the underlined tab variant before taking screenshots.

Changes:

  • Re-enabled previously disabled tabs e2e test by removing test.fixme wrapper
  • Added data-testid attribute to the underlined tab group for targeted selection
  • Implemented a click action on a specific tab to stabilize bottom outline rendering before screenshot capture

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/components/tabs/e2e.ts Added data-testid="e2eTabsUnderlined" to the underlined tab group for test targeting
packages/components/tabs/e2e.playwright-spec.ts Removed test.fixme, added helper function, and implemented click workaround to ensure stable rendering

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

github-actions Bot commented Feb 3, 2026

Copy link
Copy Markdown

🚨 E2E tests failed

Review the report for details.


💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions

github-actions Bot commented Feb 3, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 60cb630):

https://koobiq-next--prs-1348-vypwk5z2.web.app

(expires Sun, 08 Feb 2026 12:37:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@artembelik

Copy link
Copy Markdown
Contributor Author

/approve-snapshots

@github-actions

github-actions Bot commented Feb 3, 2026

Copy link
Copy Markdown

🔄 Updating snapshots.

@github-actions

github-actions Bot commented Feb 3, 2026

Copy link
Copy Markdown

✅ Snapshots updated!

@github-actions github-actions Bot requested a review from lskramarov as a code owner February 3, 2026 12:31
@artembelik artembelik merged commit e60d108 into main Feb 5, 2026
8 checks passed
@artembelik artembelik deleted the fix/DS-4627 branch February 5, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants