chore(e2e): resolved flaky tabs test (#DS-4627)#1348
Conversation
There was a problem hiding this comment.
Pull request overview
This PR resolves a flaky end-to-end test for the tabs component by implementing a workaround that ensures proper rendering of the underlined tab variant before taking screenshots.
Changes:
- Re-enabled previously disabled tabs e2e test by removing
test.fixmewrapper - Added
data-testidattribute to the underlined tab group for targeted selection - Implemented a click action on a specific tab to stabilize bottom outline rendering before screenshot capture
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/components/tabs/e2e.ts | Added data-testid="e2eTabsUnderlined" to the underlined tab group for test targeting |
| packages/components/tabs/e2e.playwright-spec.ts | Removed test.fixme, added helper function, and implemented click workaround to ensure stable rendering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
Visit the preview URL for this PR (updated for commit 60cb630): https://koobiq-next--prs-1348-vypwk5z2.web.app (expires Sun, 08 Feb 2026 12:37:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
No description provided.