Skip to content

fix(docs): initial theme (#DS-4666)#1350

Merged
artembelik merged 1 commit into
mainfrom
fix/DS-4666
Feb 4, 2026
Merged

fix(docs): initial theme (#DS-4666)#1350
artembelik merged 1 commit into
mainfrom
fix/DS-4666

Conversation

@artembelik

Copy link
Copy Markdown
Contributor

No description provided.

@artembelik artembelik self-assigned this Feb 3, 2026
Copilot AI review requested due to automatic review settings February 3, 2026 13:40
@artembelik artembelik added the bug Something isn't working label Feb 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the docs app’s theming behavior, particularly around initial theme selection and OS-based auto-theming, and addresses an Angular change-detection warning.

Changes:

  • Updates DocsWelcomeComponent to derive the current theme name more defensively from the ThemeService stream.
  • Refactors DocsNavbarComponent to inject ThemeService and ChangeDetectorRef via inject, defer the initial theme application using afterNextRender to avoid NG0100, and harden auto-theme handling with a guard on the theme list.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
apps/docs/src/app/components/welcome/welcome.component.ts Adjusts mapping from the current theme to a string used in the welcome component, adding a null-safe check (though with an incomplete guard; see comment).
apps/docs/src/app/components/navbar/navbar.component.ts Refactors theme-related initialization to use afterNextRender and injected services, and adds a safety check when mutating the auto theme configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/docs/src/app/components/welcome/welcome.component.ts
@github-actions

github-actions Bot commented Feb 3, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit d7a76d7):

https://koobiq-next--prs-1350-ynychvow.web.app

(expires Sun, 08 Feb 2026 13:44:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@artembelik artembelik merged commit 2a37644 into main Feb 4, 2026
15 checks passed
@artembelik artembelik deleted the fix/DS-4666 branch February 4, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants