fix(docs): initial theme (#DS-4666)#1350
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the docs app’s theming behavior, particularly around initial theme selection and OS-based auto-theming, and addresses an Angular change-detection warning.
Changes:
- Updates
DocsWelcomeComponentto derive the current theme name more defensively from theThemeServicestream. - Refactors
DocsNavbarComponentto injectThemeServiceandChangeDetectorRefviainject, defer the initial theme application usingafterNextRenderto avoid NG0100, and harden auto-theme handling with a guard on the theme list.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
apps/docs/src/app/components/welcome/welcome.component.ts |
Adjusts mapping from the current theme to a string used in the welcome component, adding a null-safe check (though with an incomplete guard; see comment). |
apps/docs/src/app/components/navbar/navbar.component.ts |
Refactors theme-related initialization to use afterNextRender and injected services, and adds a safety check when mutating the auto theme configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Visit the preview URL for this PR (updated for commit d7a76d7): https://koobiq-next--prs-1350-ynychvow.web.app (expires Sun, 08 Feb 2026 13:44:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
lskramarov
approved these changes
Feb 3, 2026
NikGurev
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.