Rename entityConfig to entityBlueprint in Korge-fleks gradle task#2358
Merged
Rename entityConfig to entityBlueprint in Korge-fleks gradle task#2358
Conversation
🤖 Augment PR SummarySummary: Updates the Korge-fleks Gradle exporter to use the LDtk field name 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| val entityConfigField = ldtkEntities.first { it["__identifier"] == "entityConfig" } | ||
| val entityConfigType = entityConfigField["__value"]?.let { it as String } ?: error("Entity config field '__value' is null for entity '$entityName' in chunk '$chunkName'!") | ||
| val entityBlueprintField = ldtkEntities.first { it["__identifier"] == "entityBlueprint" } | ||
| val entityBlueprintType = entityBlueprintField["__value"]?.let { it as String } ?: error("Entity config field '__value' is null for entity '$entityName' in chunk '$chunkName'!") |
There was a problem hiding this comment.
The thrown error message still says "Entity config field" even though the identifier is now entityBlueprint, which could be confusing when debugging null __value cases.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.