Support hide_window_decorations titlebar-only on Wayland#9486
Support hide_window_decorations titlebar-only on Wayland#9486antoinecellerier wants to merge 1 commit intokovidgoyal:masterfrom
Conversation
|
What manual testing did you do? In particular the main source of issues If a value of titlebar-only disables SSD then a value of yes should Finally update the changelog with an entry for this. I am rather busy at the moment, with a whole queue of AI generated PRs |
|
I've mostly tested keyboard based resizing/tiling, mouse based resizing, changing the config vague and reloading (no effect). This is the list of scenarios copilot had come up with for me to validate:
My understanding is that my Gnome / Wayland setup uses SSD but I'm trusting AI on this one ... Let me check the other items and add missing docs / changelog entries to the pr. |
648fa15 to
5738d80
Compare
|
I've validated right clicking in the shadow area doesn't do anything & added extra doc and changelog entries. Happy to run any other tests if useful. thanks |
Hide the CSD titlebar subsurface while keeping shadow borders for resizing. On SSD compositors (GNOME), forces CSD mode to draw kitty's own shadows without a titlebar. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
5738d80 to
ef4574a
Compare
|
I'm confused. GNOME is almost unique amongst Wayland compositors for not supporting SSD. This needs to be tested on something like kwin or niri or sway or hyprland that do support SSD. Does using CSD there via this options cause any issues? Does setting this option to yes also force usage of CSD or does that happen for titlebar-only? |
|
Got it. maybe Opus was misrepresenting things to me. Will test it one one of those other options and report back. |
Hide the CSD titlebar subsurface while keeping shadow borders for resizing. On SSD compositors (GNOME), forces CSD mode to draw kitty's own shadows without a titlebar.
Manually tested on the following:
This PR was authored by GitHub Copilot / Opus 4.6. I'm not familiar with the kitty code base nor wayland window compositing but reading through the changes they feel reasonable. If you feel this is garbage, please let me know :)