feat: add windows binary to goreleaser.yaml#3962
feat: add windows binary to goreleaser.yaml#3962nadworny wants to merge 1 commit intokptdev:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@nadworny I'm not necessarily against distributing a Windows binary of kpt, but I think we first would have to make sure we have automated tests for Windows. Most of the contributors to kpt doesn't use Windows and don't have easy access to Windows machines for testing during development. |
|
hey @mortent , same here (I'm on macOS) ;) but we have just a few Windows users that would like to use it. I also don't have any experience running Windows tests on Github so not sure how to proceed. |
|
So we haven't had a lot of requests for Windows support for kpt and we do think it will require some work to set up the infrastructure for testing and for making sure features work well on Windows. So we don't really think it is worth setting up the infrastructure for making Windows releases at this point. If you want to use kpt on Windows, you are of course free to build from source and we are happy to accept fixes to improve the way kpt runs on Windows. But please also add an issue for this and then we can see if we get more interest in supporting Windows. If we do get interest from others, then we can revisit it. |
|
@efiacor is this interesting for us or is it difficult to do? |
I would agree with this from @mortent |
|
We have no plans to provide Windows binaries at the moment. See the comment from @mortent |
Support windows binary