Allow Kptfile pipeline functions to reference config by resource name#4178
Open
mansoor17syed wants to merge 1 commit intokptdev:mainfrom
Open
Allow Kptfile pipeline functions to reference config by resource name#4178mansoor17syed wants to merge 1 commit intokptdev:mainfrom
mansoor17syed wants to merge 1 commit intokptdev:mainfrom
Conversation
…ced by config by resource name Signed-off-by: mansoora <syed.mansoor_a@nokia.com>
Contributor
|
This looks like a good addition, We need to find time to pull it down and try it out. Also we need to add an e2e test for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for referencing existing resources in the package as function configs. This allows users to reference existing resources (like ConfigMaps) in their package as function configurations instead of duplicating the configuration in the Kptfile.
Motivation
Currently, function configurations can only be specified using
configPathorconfigMap. This requires users to either maintain separate configuration files or duplicate configurations in the Kptfile. By allowing references to existing resources, we can:Changes
ResourceReferencetype inpkg/api/kptfile/v1/types.gopkg/api/kptfile/v1/validation.gopkg/api/kptfile/v1/validation_test.goTesting
Fixes #3515