Bump poko-gradle-plugin with a workaround (enforce compatible Kotlin version)#3035
Merged
Merged
Conversation
5202afd to
9840e30
Compare
poko-gradle-plugin with a workaroundpoko-gradle-plugin with a workaround (enforce compatible Kotlin version)
This was referenced Jul 5, 2025
Co-authored-by: Mateusz Kwieciński <36954793+mateuszkwiecinski@users.noreply.github.com>
Goooler
reviewed
Jul 6, 2025
| @@ -1,4 +1,6 @@ | |||
| plugins { | |||
| // TODO: Remove if the build is migrated to Gradle 9 | |||
| kotlin("jvm") version libs.versions.kotlin.get() apply false // Enforce higher Kotlin version to make `poko-gradle-plugin` compatible. | |||
Contributor
There was a problem hiding this comment.
I believe we can bump the project used Gradle to 9.0.0-rc-1 for now. But that should be addressed in a separate PR.
This was referenced Jul 6, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For the
build-logicprojectkotlin-dslplugin (5.2.0) sets its own recommended kotlin version (2.0.21), which is not compatible with latest poko plugin. Our options are:build-logicprojectThis PR implements option 2).
Checklist
Before submitting the PR, please check following (checks which are not relevant may be ignored):
Closes #<xxx>orFixes #<xxx>(replace<xxx>with issue number)Documentation is updated. See difference between snapshot and release documentation