JS: Introduce helper functions for event listeners#5495
Draft
osipxd wants to merge 1 commit intorelease/3.xfrom
Draft
JS: Introduce helper functions for event listeners#5495osipxd wants to merge 1 commit intorelease/3.xfrom
osipxd wants to merge 1 commit intorelease/3.xfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0666f3b to
f7a5d01
Compare
Contributor
|
Good call 👍 |
3f26045 to
5a9cf5a
Compare
5a9cf5a to
96416ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subsystem
JS/WasmJS client
Motivation
The existing approach was error-prone: it was easy to forget to call
removeEventListenerfor one-time listeners, and the only correct implementation required alateinit varto hold the callback reference so it could be removed inside itself.Solution
Introduces two internal helpers in the
websource set (shared betweenjsandwasmJs):EventTarget.addEventListener<T>(vararg events, listener)— type-safe wrapper that captures the callback internally and returns aDisposableHandle, eliminating the need to keep a separate lambda reference for cleanup.EventTarget.addOneTimeEventListener<T>(vararg events, listener)— registers a listener that automatically removes itself after the first matching event fires, replacing thelateinit varpattern.Refactors
JsClientEngine,WasmJsClientEngine, andJsWebSocketSession(bothjsandwasmJs) to use these helpers.