Skip to content

chore(runtimes): Remove MPI pi Runtime#2760

Merged
google-oss-prow[bot] merged 4 commits into
kubeflow:masterfrom
andreyvelich:remove-mpi
Aug 18, 2025
Merged

chore(runtimes): Remove MPI pi Runtime#2760
google-oss-prow[bot] merged 4 commits into
kubeflow:masterfrom
andreyvelich:remove-mpi

Conversation

@andreyvelich

Copy link
Copy Markdown
Member

As we discussed in the Slack thread, we can remove the mpi-distributed runtime if favour of MPI-based runtimes like DeepSpeed and MLX: https://cloud-native.slack.com/archives/C0742LDFZ4K/p1753783021564389?thread_ts=1753710956.860929&cid=C0742LDFZ4K

/hold for review

/assign @kubeflow/kubeflow-trainer-team @astefanutti

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@coveralls

coveralls commented Jul 29, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 17026006406

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+47.8%) to 47.791%

Totals Coverage Status
Change from base Build 16592909581: 47.8%
Covered Lines: 941
Relevant Lines: 1969

💛 - Coveralls

@Electronic-Waste Electronic-Waste left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreyvelich Thanks for creating this!
/lgtm
/approve

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Electronic-Waste

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Electronic-Waste

Copy link
Copy Markdown
Member

/retest

@andreyvelich

Copy link
Copy Markdown
Member Author

I still need to fix the E2Es, let's discuss the runtime deprecation policy before merging this: https://cloud-native.slack.com/archives/C0742LDFZ4K/p1753783715133799?thread_ts=1753710956.860929&cid=C0742LDFZ4K

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@google-oss-prow google-oss-prow Bot added size/M and removed size/L labels Aug 17, 2025
@andreyvelich

Copy link
Copy Markdown
Member Author

@tenzen-y @Electronic-Waste @astefanutti I fixed the E2Es.
/hold cancel

@astefanutti

Copy link
Copy Markdown
Contributor

/lgtm

Thanks @andreyvelich!

@google-oss-prow google-oss-prow Bot added the lgtm label Aug 18, 2025
@google-oss-prow google-oss-prow Bot merged commit c534799 into kubeflow:master Aug 18, 2025
20 checks passed
@google-oss-prow google-oss-prow Bot added this to the v2.1 milestone Aug 18, 2025
@andreyvelich andreyvelich deleted the remove-mpi branch August 18, 2025 09:58
alexxfan pushed a commit to red-hat-data-services/trainer that referenced this pull request Nov 24, 2025
* chore(runtimes): Remove MPI pi Runtime

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Add e2e tests for DeepSpeed and MLX runtimes

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* load runtime images to Kind

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Remove MLX from e2e

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

---------

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants