chore(runtimes): Remove MPI pi Runtime#2760
Conversation
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Pull Request Test Coverage Report for Build 17026006406Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Electronic-Waste
left a comment
There was a problem hiding this comment.
@andreyvelich Thanks for creating this!
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Electronic-Waste The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
I still need to fix the E2Es, let's discuss the runtime deprecation policy before merging this: https://cloud-native.slack.com/archives/C0742LDFZ4K/p1753783715133799?thread_ts=1753710956.860929&cid=C0742LDFZ4K |
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
|
@tenzen-y @Electronic-Waste @astefanutti I fixed the E2Es. |
|
/lgtm Thanks @andreyvelich! |
* chore(runtimes): Remove MPI pi Runtime Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Add e2e tests for DeepSpeed and MLX runtimes Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * load runtime images to Kind Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Remove MLX from e2e Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> --------- Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
As we discussed in the Slack thread, we can remove the
mpi-distributedruntime if favour of MPI-based runtimes like DeepSpeed and MLX: https://cloud-native.slack.com/archives/C0742LDFZ4K/p1753783021564389?thread_ts=1753710956.860929&cid=C0742LDFZ4K/hold for review
/assign @kubeflow/kubeflow-trainer-team @astefanutti