chore(operator): Upgrade Kubernetes to v1.34#2804
Conversation
Pull Request Test Coverage Report for Build 17300321569Details
💛 - Coveralls |
Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>
|
/lgtm |
| } | ||
| if diff := cmp.Diff(tc.wantClTrainingRuntime, &gotClRuntime, | ||
| cmpopts.IgnoreFields(metav1.ObjectMeta{}, "ResourceVersion"), | ||
| cmpopts.IgnoreFields(metav1.TypeMeta{}, "Kind", "APIVersion"), |
There was a problem hiding this comment.
why do we need to ignore those?
There was a problem hiding this comment.
I think there have been some changes that makes the client removing the Kind field because it's considered only client-side only.
There was a problem hiding this comment.
Ah, I see. The deserialization / serialization rules might be changed.
Thank you.
| } | ||
| obj = &unstructured.Unstructured{Object: u} | ||
|
|
||
| //nolint:staticcheck |
There was a problem hiding this comment.
why do we need to ignore this?
There was a problem hiding this comment.
The Patch method is now deprecated as expected but this requires JobSet to upgrade before we can fully migrate to the new Apply support.
I'll take care of it in a follow up PR once the update is done on JobSet side.
There was a problem hiding this comment.
That makes sense.
LMK once you open PR.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We will do this once we publish the new KF Trainer release @kramaranya |
|
@astefanutti Please can you also update the website: https://www.kubeflow.org/docs/components/trainer/operator-guides/installation/#prerequisites ? |
@andreyvelich sure, I've open kubeflow/website#4191. |
Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr> Signed-off-by: Tarun Duhan <itarunduhan@gmail.com>
Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>
5 participants
What this PR does / why we need it:
Upgrade Kubernetes to v1.34
/cc @kubeflow/kubeflow-trainer-team
Checklist: