Repository navigation
Roll up open Dependabot updates - #1921
brendandburns wants to merge 12 commits into
Conversation
--- updated-dependencies: - dependency-name: Microsoft.Extensions.Logging dependency-version: 10.0.12 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.Extensions.Logging dependency-version: 10.0.12 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
--- updated-dependencies: - dependency-name: Microsoft.TestPlatform.ObjectModel dependency-version: 18.10.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Microsoft.TestPlatform.ObjectModel dependency-version: 18.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
--- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.NetAnalyzers dependency-version: 10.0.401 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
--- updated-dependencies: - dependency-name: Microsoft.Extensions.Hosting dependency-version: 10.0.12 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
--- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-version: 18.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 7.0.0 to 7.1.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@fb8b358...303a32d) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-version: 7.1.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github/codeql-action/analyze](https://github.com/github/codeql-action) from 4.37.3 to 4.38.2. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@e4fba86...2892aa5) --- updated-dependencies: - dependency-name: github/codeql-action/analyze dependency-version: 4.38.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github/codeql-action/init](https://github.com/github/codeql-action) from 4.37.3 to 4.38.2. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@e4fba86...2892aa5) --- updated-dependencies: - dependency-name: github/codeql-action/init dependency-version: 4.38.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
--- updated-dependencies: - dependency-name: Xunit.StaFact dependency-version: 3.0.13 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…t.v3 - Replace xunit v2 with xunit.v3 3.2.2 in KubernetesClient.Tests.csproj - Remove MartinCostello.Logging.XUnit (which transitively pulled in xunit.core v2) - Fix OperatingSystemDependentFactAttribute to use explicit IFactAttribute re-implementation (Skip is sealed in xunit v3) - Remove 'using Xunit.Abstractions;' from 12 test files (ITestOutputHelper moved to Xunit namespace in v3) - Add xunit.v3 3.2.2 to Directory.Packages.props - Revert Kubectl.Tests.csproj to original xunit v2 (it doesn't use [Fact]/ [Theory] directly so there's no conflict) Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The central StaFact upgrade introduces xUnit v3 components into the still-xUnit-v2 Kubectl test project.
Review effort: Balanced
Findings: 1
What changed in this PR
Rolls up dependency updates and migrates KubernetesClient.Tests to xUnit v3.
Changes:
- Updates NuGet and GitHub Actions dependencies.
- Migrates test output APIs and OS-specific facts to xUnit v3.
- Aligns test-platform dependencies.
| File | Description |
|---|---|
.github/workflows/buildtest.yaml |
Updates Codecov action. |
.github/workflows/codeql-analysis.yml |
Updates CodeQL actions. |
Directory.Packages.props |
Updates centrally managed packages. |
examples/workerServiceDependencyInjection/workerServiceDependencyInjection.csproj |
Adds logging dependency. |
tests/KubernetesClient.Tests/AuthTests.cs |
Migrates xUnit output namespace. |
tests/KubernetesClient.Tests/KubernetesClient.Tests.csproj |
Migrates project to xUnit v3. |
tests/KubernetesClient.Tests/KubernetesMetricsTests.cs |
Migrates xUnit output namespace. |
tests/KubernetesClient.Tests/LeaderElection/LeaderElectionTests.cs |
Migrates xUnit output namespace. |
tests/KubernetesClient.Tests/Logging/TestOutputLogger.cs |
Migrates output helper namespace. |
tests/KubernetesClient.Tests/Logging/TestOutputLoggerProvider.cs |
Migrates output helper namespace. |
tests/KubernetesClient.Tests/Logging/TestOutputLoggingExtensions.cs |
Migrates output helper namespace. |
tests/KubernetesClient.Tests/Mock/MockKubeApiServer.cs |
Migrates output helper namespace. |
tests/KubernetesClient.Tests/OperatingSystemDependentFactAttribute.cs |
Implements xUnit v3 fact metadata. |
tests/KubernetesClient.Tests/PodExecTests.cs |
Migrates xUnit output namespace. |
tests/KubernetesClient.Tests/SerializationTests.cs |
Migrates xUnit output namespace. |
tests/KubernetesClient.Tests/V1StatusObjectViewTests.cs |
Migrates xUnit output namespace. |
tests/KubernetesClient.Tests/WatchTests.cs |
Migrates xUnit output namespace. |
tests/KubernetesClient.Tests/WebSocketTestBase.cs |
Migrates xUnit output namespace. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| <PackageVersion Include="xunit.runner.visualstudio" Version="3.1.5" /> | ||
| <PackageVersion Include="Xunit.StaFact" Version="1.2.69" /> | ||
| <PackageVersion Include="YamlDotNet" Version="18.0.0" /> | ||
| <PackageVersion Include="Xunit.StaFact" Version="3.0.13" /> |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |

Summary
Roll up all currently open Dependabot updates into one PR:
Xunit.StaFactto 3.0.13 and include the required xUnit v3 compatibility migrationCloses #1797
Closes #1901
Closes #1902
Closes #1904
Closes #1905
Closes #1906
Closes #1907
Closes #1908
Closes #1909
Closes #1910
Closes #1916
Closes #1919
Closes #1920
Validation
dotnet build --configuration ReleaseKubernetesClient.Testson .NET 10: 209 passed