Added a fuction/method setTerminalsize in Exec.ExecBuilber

[sriganeshres]

I have added a function in Exec.ExecBuilder class which helps to set the Terminal size.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sriganeshres
Once this PR has been reviewed and has the lgtm label, please assign brendandburns for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[linux-foundation-easycla]

• ✅login: sriganeshres / (ef580a6)

The committers listed above are authorized under a signed CLA.

[k8s-ci-robot]

Welcome @sriganeshres!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[sriganeshres]

related to #3641

[brendandburns]

This isn't quite correct. What you need to do is to add a setTerminalSize(...) method to the Exec class, that method can only run once execute() has been called and the connection is established.

[brendandburns]

Please revert all formatting changes here and below.

[brendandburns]

Thanks for starting this. Two notes:
First, please don't include any unrelated formatting changes, it makes it harder to review the PR, you can use git diff HEAD~1 to visualize any differences in your commit before you send the PR.

Second, this change isn't quite correct, you need to add a utility method to the Exec class, not to the builder. The builder is what sets up an Exec instance, but the terminal resize can only happen once the exec call starts. If the method is added to the Exec class, then someone who starts a call to Exec can resize the stream once the connection is established.

[sriganeshres]

Sorry @brendandburns for very very late response. But can you guide me more than just that im facing a bit of issue here while trying to maintain that it should be able to be run after execute(). Thanks for the support till now.

[brendandburns]

Closing this in favor of #3801

@sriganeshres thanks for getting this started. If you want to see how I suggested making the changes please check out the diff in #3801