This repository was archived by the owner on Sep 30, 2020. It is now read-only.
[v0.14.x] Always create dnsmasq-node-coredns-local.yaml#1902
Merged
dominicgunn merged 2 commits intoAug 25, 2020
Merged
Conversation
If this file does not exist (as would be the case if the CoreDNS local
feature has not been enabled), controller nodes will fail to come up
with the error:
> error: the path "/srv/kubernetes/manifests/dnsmasq-node-coredns-local.yaml" does not exist
This is caused when `kubectl delete` is called against the file because
of the line `remove "${mfdir}/dnsmasq-node-coredns-local.yaml`.
This manifest must always be generated because the CoreDNS-local
feature cannot be enabled and then later disabled without otherwise
requiring manual operator intervention.
k8s-ci-robot
added
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kfr2
changed the title
This ServiceAccount must exist whether or not CoreDNS-local has been enabled. Therefore, it is created alongside the DaemonSet rather than as part of the coredns-local manifest.
k8s-ci-robot
added
size/M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this file does not exist (as would be the case if the CoreDNS local
feature has not been enabled), controller nodes will fail to come up
with the error:
This is caused when
kubectl deleteis called against the file becauseof the line
remove "${mfdir}/dnsmasq-node-coredns-local.yaml.This manifest must always be generated because the CoreDNS-local
feature cannot be enabled and then later disabled without otherwise
requiring manual operator intervention.
Additionally, a previous change added a serviceaccount reference to the
dnsmasq-node daemonset; this PR updates the cloud-config-controller
template to create this SA alongside the daemonset.