Skip to content

🌱 Remove cloud-provider flag usage#5865

Merged
k8s-ci-robot merged 3 commits into
kubernetes-sigs:mainfrom
clebs:rm-cloud-provider-flag
Mar 7, 2026
Merged

🌱 Remove cloud-provider flag usage#5865
k8s-ci-robot merged 3 commits into
kubernetes-sigs:mainfrom
clebs:rm-cloud-provider-flag

Conversation

@clebs

@clebs clebs commented Feb 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
The --cloud-provider flag is no longer needed for the kube-apiserver since k8s v1.31 and has been completely removed in v1.33 (will result in an error if provided).
This PR removes all usages of the flag to allow upgrading to k8s 1.33+.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #964
Blocks #5857

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

Remove the --cloud-provider flag from the apiserver configuration in all templates. The flag defaults to "external" and is no longer needed. Removed in kubernetes v1.33.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 10, 2026
@clebs

clebs commented Feb 10, 2026

Copy link
Copy Markdown
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 10, 2026
@clebs

clebs commented Feb 10, 2026

Copy link
Copy Markdown
Member Author

/test all

@clebs

clebs commented Feb 10, 2026

Copy link
Copy Markdown
Member Author

/retest

@clebs clebs force-pushed the rm-cloud-provider-flag branch from be6d5f4 to 1fddb6a Compare February 10, 2026 11:11
@clebs

clebs commented Feb 10, 2026

Copy link
Copy Markdown
Member Author

/test all

@clebs clebs force-pushed the rm-cloud-provider-flag branch from 1fddb6a to c69b9de Compare February 10, 2026 12:46
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 10, 2026
@clebs

clebs commented Feb 10, 2026

Copy link
Copy Markdown
Member Author

/test all

@clebs clebs force-pushed the rm-cloud-provider-flag branch 2 times, most recently from ee69dbc to 60da346 Compare February 10, 2026 15:30
@clebs

clebs commented Feb 10, 2026

Copy link
Copy Markdown
Member Author

/retest

clebs added 2 commits February 11, 2026 10:54
@clebs
fix(templates): remove cloud-provider flag from apiserver configs
c959bc5 
The --cloud-provider flag is no longer needed since k8s v1.31 and has
been completely removed in v1.33 (will result in an error if provided).

Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs
docs: update docs to not pass the cloud-provider flag to apiserver
5f1e662 
Docs that show samples of configurations passing the cloud-provider flag
to the apiserver config have been updated and an explanatory note has
been added.

Signed-off-by: Borja Clemente <bclement@redhat.com>
@clebs clebs force-pushed the rm-cloud-provider-flag branch from 424e7e0 to 5f1e662 Compare February 11, 2026 09:58
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 11, 2026
@clebs

clebs commented Feb 11, 2026

Copy link
Copy Markdown
Member Author

/retest

@damdo

damdo commented Feb 11, 2026

Copy link
Copy Markdown
Member

/test ?

@damdo

damdo commented Feb 11, 2026

Copy link
Copy Markdown
Member

/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-conformance
/test pull-cluster-api-provider-aws-e2e-clusterclass
/test pull-cluster-api-provider-aws-e2e

@clebs

clebs commented Feb 11, 2026

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@clebs

clebs commented Feb 11, 2026

Copy link
Copy Markdown
Member Author

/retest

@clebs

clebs commented Feb 12, 2026

Copy link
Copy Markdown
Member Author

/retest

@damdo

damdo commented Feb 12, 2026

Copy link
Copy Markdown
Member

/test pull-cluster-api-provider-aws-e2e

@clebs

clebs commented Feb 12, 2026

Copy link
Copy Markdown
Member Author

@damdo the full e2e job is always failing on the gpu test. I need to have a closer look.

@clebs

clebs commented Feb 13, 2026

Copy link
Copy Markdown
Member Author

/test pull-cluster-api-provider-aws-e2e

@clebs clebs force-pushed the rm-cloud-provider-flag branch from 0cbcc00 to 5f1e662 Compare February 16, 2026 17:11
@clebs

clebs commented Feb 16, 2026

Copy link
Copy Markdown
Member Author

/test all

@clebs

clebs commented Feb 16, 2026

Copy link
Copy Markdown
Member Author

/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-conformance
/test pull-cluster-api-provider-aws-e2e-clusterclass
/test pull-cluster-api-provider-aws-e2e

@damdo

damdo commented Feb 17, 2026

Copy link
Copy Markdown
Member

/retest

@clebs
test(gpu): skip gpu tests
5532763 
Temporarily skip GPU tests until they are updated or refactored as per kubernetes-sigs#5870

Signed-off-by: Borja Clemente <borja.clemente@gmail.com>
@clebs

clebs commented Feb 17, 2026

Copy link
Copy Markdown
Member Author

/test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e-conformance
/test pull-cluster-api-provider-aws-e2e-clusterclass
/test pull-cluster-api-provider-aws-e2e

@clebs

clebs commented Feb 17, 2026

Copy link
Copy Markdown
Member Author

/retest

@damdo

damdo commented Feb 17, 2026

Copy link
Copy Markdown
Member

@clebs CI slots are full, we need to wait for them to clear up and try again those failing ones

@damdo

damdo commented Feb 17, 2026

Copy link
Copy Markdown
Member

/test pull-cluster-api-provider-aws-e2e-conformance
/test pull-cluster-api-provider-aws-e2e-clusterclass

@damdo

damdo commented Feb 17, 2026

Copy link
Copy Markdown
Member

/retest

@damdo

damdo commented Feb 17, 2026

Copy link
Copy Markdown
Member

/test pull-cluster-api-provider-aws-e2e

1 similar comment
@damdo

damdo commented Mar 7, 2026

Copy link
Copy Markdown
Member

/test pull-cluster-api-provider-aws-e2e

damdo
damdo reviewed Mar 7, 2026
View reviewed changes

@damdo damdo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2026
@k8s-ci-robot

k8s-ci-robot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: aa8e829be33605d28b7d8def6b8a3b968ca386d3

@k8s-ci-robot

k8s-ci-robot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2026
@k8s-ci-robot k8s-ci-robot merged commit cd34271 into kubernetes-sigs:main Mar 7, 2026
22 checks passed
@clebs clebs deleted the rm-cloud-provider-flag branch March 7, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo damdo left review comments
@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky
@richardcase richardcase Awaiting requested review from richardcase

Assignees

@damdo damdo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Default to out-of-tree cloud provider

3 participants

@clebs @damdo @k8s-ci-robot