[lbarrosby]

What this PR does / why we need it:

renameLoadBalancer reuses the oldClusterName variable for the pool's cluster-name and then uses it to rename the listener. If the pool already carries the new cluster-name but the listener does not, the listener is "renamed" from the new cluster-name to itself and keeps the old name.

This happens when a previous rename attempt renamed the pool and then failed before updating the listener (for example a timeout waiting for the LB to go ACTIVE). On the next sync the listener still has the old cluster-name, the pool is skipped, the listener update is a no-op, and the load balancer itself is renamed at the end. After that lbHasOldClusterName returns false, so the listener is never fixed.

The fix keeps the pool's cluster-name in its own variable, so the listener is always renamed using the cluster-name parsed from its own name.

Which issue this PR fixes(if applicable):
N/A

Special notes for reviewers:

Added TestRenameLoadBalancerListenerWithRenamedPool, which runs renameLoadBalancer against an httptest server with a listener named listener_0_kube_service_old_namespace_name and a pool already named pool_0_kube_service_new_namespace_name. Before the fix the listener update is sent with the old name and the test fails; with the fix it gets listener_0_kube_service_new_namespace_name. go test ./pkg/openstack/ and golangci-lint run ./pkg/openstack/... pass.

This PR was written in part with the assistance of generative AI.

Release note:

[openstack-cloud-controller-manager] Fixed a listener keeping the old cluster-name after a cluster-name change when its pool had already been renamed.

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign anguslees for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/openstack/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubernetes-prow]

Welcome @lbarrosby!

It looks like this is your first PR to kubernetes/cloud-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[kubernetes-prow]

Hi @lbarrosby. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.