Withdraw alpha support for HostNetwork containers on Windows

[marosset]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Removes alpha support for HostNetwork on Windows

Which issue(s) this PR fixes:

Part of kubernetes/enhancements#3503

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Removed alpha support for Windows HostNetwork containers.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://github.com/kubernetes/enhancements/issues/3503

/milestone v1.33
/sig windows node network
/area kubelet

[marosset]

/triage accepted
/priority important-longterm

[nitishfy]

We are moving towards the code freeze soon. Tagging reviewers to know the status of this PR.
cc @dims / @sftim

[dims]

/retest
/approve
/lgtm

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: cdcbc5b7781e9c0c22c07cdf73ea25de02942441

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest

[dims]

from: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/130250/pull-kubernetes-unit/1894082215894061056

k8s.io/kubernetes/pkg/kubelet: kuberuntime expand_less | 1s
-- | --
{Failed  === RUN   TestGeneratePodSandboxWindowsConfig_HostProcess/Empty_PodSecurityContext --- FAIL: TestGeneratePodSandboxWindowsConfig_HostProcess/Empty_PodSecurityContext (0.00s)  === RUN   TestGeneratePodSandboxWindowsConfig_HostProcess --- FAIL: TestGeneratePodSandboxWindowsConfig_HostProcess (0.00s) panic: runtime error: invalid memory address or nil pointer dereference [recovered] 	panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x3e0a6df]  goroutine 666 [running]: testing.tRunner.func1.2({0x41c7aa0, 0x69e4490}) 	/usr/local/go/src/testing/testing.go:1632 +0x3fc testing.tRunner.func1() 	/usr/local/go/src/testing/testing.go:1635 +0x6b6 panic({0x41c7aa0?, 0x69e4490?}) 	/usr/local/go/src/runtime/panic.go:785 +0x132 k8s.io/kubernetes/pkg/kubelet/kuberuntime.(*kubeGenericRuntimeManager).generatePodSandboxWindowsConfig(0x4c99ef0?, 0xc000565a70) 	/home/prow/go/src/k8s.io/kubernetes/pkg/kubelet/kuberuntime/kuberuntime_sandbox.go:241 +0x13f k8s.io/kubernetes/pkg/kubelet/kuberuntime.TestGeneratePodSandboxWindowsConfig_HostProcess.func1(0xc0007169c0) 	/home/prow/go/src/k8s.io/kubernetes/pkg/kubelet/kuberuntime/kuberuntime_sandbox_test.go:388 +0x128 testing.tRunner(0xc0007169c0, 0xc00072a640) 	/usr/local/go/src/testing/testing.go:1690 +0x227 created by testing.(*T).Run in goroutine 663 	/usr/local/go/src/testing/testing.go:1743 +0x826 }

[dims]

/hold

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: 0de6373c7cd22f55f9fc762530bfe20c229f6e55

[BenTheElder]

needs a rebase (the versioned_feature_list file moved)

[BenTheElder]

@dims looks like the test panic was fixed in #130250 (comment), do we still need the hold?

[dims]

/hold cancel

sorry @BenTheElder removed the hold now.

[nitishfy]

Appreciate all of your efforts with this PR. Is the plan still to resolve it for v1.33 release?
If so, a gentle reminder that the code freeze has started 02:00 UTC Friday 21st March 2025 . Please make sure any PRs have both lgtm and approved labels ASAP, and file an Exception if you haven't done it yet.
Thanks!

[sftim]

The PR changelog entry doesn't look quite right; I recommend checking it.

Ideally it is in past tense. But also check the formatting.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/features/OWNERS [dims,marosset]
• pkg/kubelet/OWNERS [dims]
• staging/src/k8s.io/cri-api/OWNERS [dims]
• test/compatibility_lifecycle/reference/OWNERS [dims,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[marosset]

The PR changelog entry doesn't look quite right; I recommend checking it.

Ideally it is in past tense. But also check the formatting.

Updated both the tense and formatting

[jsturtevant]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: 96d018a65a7c0a5f20a824bccc353afdf4d839d8

[marosset]

/retest

[BenTheElder]

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/130250/pull-kubernetes-unit/1901691460063858688
#130018

[pacoxu]

The logic were removed after marking the FG as Deprecated. Is this a general pattern?

IIRC, we should remove the logical once we removed the FG(or locked the FG to true/false).

cc @dims @BenTheElder @siyuanfoundation

[siyuanfoundation]

This is alpha feature. So it is ok to remove them directly without the deprecation phase. We don't need to keep the feature gate definition in the code base.

[BenTheElder]

It's a bit unusual, in that it was on by default as an alpha, and for a long time, it might be possible that users depended on this without realizing it was alpha.

Otherwise yes, alphas can be removed without notice ...