MTV-3613 | fix transient ConnectionTestFailed error#4496
Merged
mnecas merged 3 commits intokubev2v:mainfrom Feb 13, 2026
Merged
MTV-3613 | fix transient ConnectionTestFailed error#4496mnecas merged 3 commits intokubev2v:mainfrom
mnecas merged 3 commits intokubev2v:mainfrom
Conversation
…ider When an ova provider is created, we need to wait for the ova-server-provider pods to come up and be able to respond to requests. Currently, what is happening is that we're attempting to test the connection immediately and returning a ConnectionTestFailed condition simply because the ova-provider-server pod has not been created and is not waiting for requests. After the pod becomes ready, the provider succeeds and the error condition is cleared, but this causes confusion to users. Introduce a new WaitingForService condition that is shown until the service becomes available. Resolves: MTV-3613 Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
We want to always end the staging conditions, so put it in a defer function to ensure it gets called even when returning early from the reconcile function (e.g. if validation fails). Resolves: MTV-3613 Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
This allows us to verify that the http server is ready to receive requests before marking the pod as ready. It eliminates a potential short race condition where the provider might set a connection failure status after an ova provider is created but before the pod is ready. Resolves: MTV-3613 Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
jonner
requested review from
Hazanel,
mnecas,
mrnold,
solenoci and
yaacov
as code owners
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4496 +/- ##
=========================================
- Coverage 15.45% 8.89% -6.56%
=========================================
Files 112 468 +356
Lines 23377 53480 +30103
=========================================
+ Hits 3613 4759 +1146
- Misses 19479 48317 +28838
- Partials 285 404 +119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yaacov
reviewed
Jan 29, 2026
yaacov
approved these changes
Jan 29, 2026
Member
yaacov
left a comment
yaacov
left a comment
There was a problem hiding this comment.
lgtm, nitpick: i have concerns about the "fail to get deployment" case
mnecas
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a previous attempt to fix this bug in commit 2aafff4, but it wasn't a complete fix. This patch series should fully fix the issue. The first commit is the most important:
The other two minor commits fix some small related corner cases or race conditions: