Move applyStorageProfile constant to API package by noamasu · Pull Request #3962 · kubevirt/containerized-data-importer

noamasu · 2025-12-01T10:28:20Z

Moving cdi.kubevirt.io/applyStorageProfile to the API package.

What this PR does / why we need it:
This enables external projects (e.g., KubeVirt) to import the constant from the API package instead of duplicating it.

Add LabelApplyStorageProfile to containerized-data-importer-api package for external consumer access
Update CDI code to use cdiv1.LabelApplyStorageProfile

Which issue(s) this PR fixes:
Part of a fix for # https://issues.redhat.com/browse/CNV-73408

This kubevirt/kubevirt#16229 PR in kubevirt relies on this change.

Special notes for your reviewer:
@arnongilboa
@ShellyKa13

Release note:

NONE

kubevirt-bot · 2025-12-01T10:28:29Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign aglitke for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coveralls · 2025-12-01T10:41:03Z

coverage: 58.669% (+0.02%) from 58.652%
when pulling 36bfa8d on noamasu:bugfix/move-applystorageprofile-to-cdi-api
into a6f7fd8 on kubevirt:main.

arnongilboa · 2025-12-01T11:44:19Z

+	// Deprecated: Use cdiv1.LabelApplyStorageProfile from containerized-data-importer-api instead.
+	// This constant is kept for backwards compatibility and will be removed in a future release.
+	PvcApplyStorageProfileLabel = cdiv1.LabelApplyStorageProfile


why keep it if all refs are updated?

Still appears in the commit message and the PR description.

arnongilboa · 2025-12-02T06:47:56Z


+// LabelApplyStorageProfile is a PVC label that tells the CDI mutating webhook to modify the PVC
+// according to the storage profile. When set to "true", the webhook will process the PVC based on
+// its associated StorageProfile (e.g., setting volume mode, access modes, etc.).


in the e.g. you may add "minimum supported pvc size", as it's the main motivation for its usage in kubevirt via the api.

- Add LabelApplyStorageProfile to containerized-data-importer-api package for external consumer access - Update CDI code to use cdiv1.LabelApplyStorageProfile This enables external projects (e.g., KubeVirt) to import the constant from the API package instead of duplicating it. Signed-off-by: Noam Assouline <nassouli@redhat.com>

arnongilboa · 2025-12-03T10:05:08Z

/lgtm

kubevirt-bot · 2025-12-10T10:36:02Z

Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

kubevirt-bot · 2026-02-27T08:54:46Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot · 2026-05-07T12:43:38Z

There has been no activity on this PR for 45 days.
To protect limited CI resources, it has been automatically labelled 'stale'.
This PR will automatically rot after an additional 14 days of inactivity, and will be closed shortly after that.

What you can do:

If the PR is waiting on you to respond to a question or feedback and/or update the PR, please do so.
You can mark the PR as fresh and remove the label with the following command: /remove-lifecycle stale
If this PR is safe to close now, please help the project by closing it with: /close
If you need attention on this PR from a reviewer, you can raise it on the agenda of the relevant SIG meeting or KubeVirt Community meeting, or ping the kubevirt-dev slack channel.

/lifecycle stale

kubevirt-bot · 2026-05-21T13:20:51Z

There has been no activity on this PR for 59 days and it has been stale for 14 days.
To protect limited CI resources, it has been automatically labelled 'rotten' and will be closed in 7 days.

What you can do:

If the PR is waiting on you to respond to a question or feedback and/or update the PR, please do so.
You can mark the PR as fresh and remove the label with the following command: /remove-lifecycle rotten
If this PR is safe to close now, please help the project by closing it with: /close
If you need attention on this PR from a reviewer, you can raise it on the agenda of the relevant SIG meeting or KubeVirt Community meeting, or ping the kubevirt-dev slack channel.

/lifecycle rotten

kubevirt-bot · 2026-05-28T13:36:12Z

There has been no activity on this PR for 66 days and it has been rotten for 7 days.
To protect limited CI resources, it has been automatically closed.

What you can do:

If the PR is waiting on you to respond to a question or feedback and/or update the PR, please do so.
You can reopen the PR with the following command: /reopen
Raise attention on this PR at a relevant SIG meeting or KubeVirt Community meeting, or ping the kubevirt-dev slack channel.

/close

kubevirt-bot · 2026-05-28T13:36:17Z

@kubevirt-bot: Closed this PR.

Details

In response to this:

There has been no activity on this PR for 66 days and it has been rotten for 7 days.
To protect limited CI resources, it has been automatically closed.

What you can do:

If the PR is waiting on you to respond to a question or feedback and/or update the PR, please do so.

You can reopen the PR with the following command: /reopen

Raise attention on this PR at a relevant SIG meeting or KubeVirt Community meeting, or ping the kubevirt-dev slack channel.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot · 2026-05-28T15:51:58Z

/remove-label needs-approver-review

kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 1, 2025

kubevirt-bot requested a review from aglitke December 1, 2025 10:28

kubevirt-bot requested a review from akalenyu December 1, 2025 10:28

kubevirt-bot added size/M release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 1, 2025

arnongilboa reviewed Dec 1, 2025

View reviewed changes

noamasu force-pushed the bugfix/move-applystorageprofile-to-cdi-api branch 2 times, most recently from 4f3e82f to 379b3a2 Compare December 1, 2025 13:34

arnongilboa reviewed Dec 2, 2025

View reviewed changes

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2025

noamasu force-pushed the bugfix/move-applystorageprofile-to-cdi-api branch from 379b3a2 to 63cc5d7 Compare December 2, 2025 10:05

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2025

noamasu force-pushed the bugfix/move-applystorageprofile-to-cdi-api branch from 63cc5d7 to 36bfa8d Compare December 2, 2025 10:12

kubevirt-bot assigned arnongilboa Dec 3, 2025

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2025

kubevirt-bot added the needs-approver-review Indicates that a PR requires a review from an approver. label Dec 10, 2025

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2026

kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 7, 2026

kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 21, 2026

kubevirt-bot closed this May 28, 2026

kubevirt-bot removed the needs-approver-review Indicates that a PR requires a review from an approver. label May 28, 2026

Uh oh!

Conversation

noamasu commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kubevirt-bot commented Dec 1, 2025

Uh oh!

coveralls commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arnongilboa Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

noamasu Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

arnongilboa Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

arnongilboa Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

arnongilboa commented Dec 3, 2025

Uh oh!

kubevirt-bot commented Dec 10, 2025

Uh oh!

kubevirt-bot commented Feb 27, 2026

Uh oh!

kubevirt-bot commented May 7, 2026

Uh oh!

kubevirt-bot commented May 21, 2026

Uh oh!

kubevirt-bot commented May 28, 2026

Uh oh!

kubevirt-bot commented May 28, 2026

Uh oh!

kubevirt-bot commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

noamasu commented Dec 1, 2025 •

edited

Loading

coveralls commented Dec 1, 2025 •

edited

Loading