tests(helm): Annotated crds_test.yml for helm unittest >= 1.1.0#1730
Merged
Conversation
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
github-project-automation
Bot
moved this to Pending review
in Kubewarden Admission Controller
This was referenced May 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Helm unittest chart tests to reference templates using explicit templates/-prefixed paths, aligning with helm-unittest >= 1.1.0 behavior (which no longer implicitly prepends templates/).
Changes:
- Updated
template:entries in the CRD unittest suite to usetemplates/crds/...paths so the tests can locate the rendered templates under newer helm-unittest versions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 11, 2026
jvanz
approved these changes
May 11, 2026
github-project-automation
Bot
moved this from Pending review
to Done
in Kubewarden Admission Controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Helm unittest >= 1.1.0 doesn't automatically prepend the
templates/prefix to the path, hence the tests were failing to find the correct files.Test
CI.
Additional Information
Tradeoff
Potential improvement
Checklist