Skip to content

Remove stale checkout workaround comments#301

Merged
flavio merged 2 commits intokubewarden:mainfrom
AkashKumar7902:issue-163-checkout-ref-cleanup
May 5, 2026
Merged

Remove stale checkout workaround comments#301
flavio merged 2 commits intokubewarden:mainfrom
AkashKumar7902:issue-163-checkout-ref-cleanup

Conversation

@AkashKumar7902
Copy link
Copy Markdown
Contributor

Summary

  • remove the obsolete Add option to fetch tags even if fetch-depth > 0 actions/checkout#579 workaround comment from reusable policy release workflows
  • keep fetch-depth: 0 because the version calculation still uses git describe for tag and branch builds
  • apply the same cleanup to normal policy workflows and the Rego workflow used by monorepo policies

Fixes #163

Testing

  • yq e . .github/workflows/reusable-release-policy-{assemblyscript,go,go-wasi,rego,rust,swift}.yml
  • git diff --check
  • verified no stale checkout#579 comments remain
  • verified first release checkout in each touched workflow still has fetch-depth: 0

Signed-off-by: Akash Kumar <meakash7902@gmail.com>
Comment thread .github/workflows/reusable-release-policy-assemblyscript.yml
Comment thread .github/workflows/reusable-release-policy-go-wasi.yml
Comment thread .github/workflows/reusable-release-policy-go.yml
Comment thread .github/workflows/reusable-release-policy-rego.yml
Comment thread .github/workflows/reusable-release-policy-rust.yml
Comment thread .github/workflows/reusable-release-policy-swift.yml
@jvanz jvanz moved this from Pending review to Blocked in Kubewarden Admission Controller Apr 28, 2026
@AkashKumar7902
Copy link
Copy Markdown
Contributor Author

Thanks, addressed in d2c53fe. I added the full-depth checkout configuration with across the reusable policy release workflows.

Signed-off-by: Akash Kumar <meakash7902@gmail.com>
@AkashKumar7902 AkashKumar7902 force-pushed the issue-163-checkout-ref-cleanup branch from d2c53fe to 3403a8d Compare April 28, 2026 17:29
@AkashKumar7902
Copy link
Copy Markdown
Contributor Author

Follow-up: amended and pushed 3403a8d with DCO signoff. The checkout changes now include fetch-depth: 0 and persist-credentials: false across the reusable policy release workflows.

@flavio flavio merged commit 264e9e5 into kubewarden:main May 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Remove leftover actions/checkout configuration for branches & tags

3 participants