Skip to content

fix(nodes): block lean-to managed column movement in both views - #34

Draft
kvnloo wants to merge 8 commits into
mainfrom
nc/pe19-1112-lean-to-move-gate
Draft

kvnloo wants to merge 8 commits into
mainfrom
nc/pe19-1112-lean-to-move-gate

Conversation

@kvnloo

@kvnloo kvnloo commented Nov 6, 2026

Copy link
Copy Markdown
Owner

Problem

Upstream #1112 leaves lean-to managed posts movable in 3D: a null override falls back to the base X/Z axes. The fork's main likewise had no managed-column movement override. Its 2D column move session also needed a corresponding no-commit guard. The upstream PR is a conflicting 167-file change set with a stale assertion that null is the intended managed override.

Design

Selectively reconcile the reviewed upstream head c3edd17a82b2c5c44942ef2da83cb24a0b734d82 with fork main 352ec93ccefa7155e60f7b9cfc6fd04c4e1b1bac: retain only the managed-post movement fix and colocated observable regressions. The branch starts at the reviewed upstream PR head; its one two-parent reconciliation commit includes current main and a narrow replacement tree. GitHub comparison against main changes only three column files. This is not a linear rebase or a claim that all 167 upstream files were ported.

  • E-001: no new dependencies or runtime Three.js in core.
  • E-002: column-owned movable.override; 2D move checks the same registry capability.
  • E-003: no persisted schema changes.
  • E-006: both 2D/3D movement constrained.
  • E-007: managed 2D sessions create no live writes or commit; existing unmanaged drag behavior remains.
  • E-010: use existing registry and tool contracts, no parallel mechanism.
  • T-001: tests use public core movement exports and the node package's index exports; no internal callback assertion or source-grep tests.

Change (at 3e15eb237ab26c7a321ecd254aaa6a2c1c266832)

Tests

All UNRUN by this GitHub-connector worker; no browser, Bun or Biome execution:

bun test packages/nodes/src/column/definition.test.ts
bun run check
bun run test
bun run ci

Hand-worked with grid snap disabled from the checked-in resolveMovable, moveToward and movePlanToward contracts:

Node / input Before After
Managed vertical [0, 0.3, 0] → [1, 4, 2] (3D) movable, [1, 0.3, 2] immovable, [0, 0.3, 0]
Managed K-brace plan [2, 1] → [2.5, 3] movable, [2.5, 3] immovable, [2, 1]; actual plan session cannot commit
Unmanaged [0, 0.3, 0] → [1, 4, 2] movable, [1, 0.3, 2] unchanged, [1, 0.3, 2]
Unmanaged plan [0, 0] → [1, 2] [1, 2] [1, 2]

These are mathematical expectations, not executed test results. GitHub compare: only three column files; main is in the new commit's ancestry, no default-branch updates.

Upstream readiness

HOLD. This is a downstream fork-only Draft PR. Upstream pascalorg#1112 is open with requested changes, and its broader pillar/elevator/roof work still requires independent review and runtime visual validation. The branch preserves upstream history (8 commits ahead despite a 3-file diff); consider clean linear history when review-ready. No upstream actions or merges.

Follow-ups

  1. Run the exact commands above and fix any failing CI/Biome/typechecks on an authorized follow-up.
  2. Verify managed and unmanaged 2D/3D pointer drags and one-gesture undo with a real scene.
  3. Split upstream Fix node dragging and refine pillars, elevators, and roofs pascalorg/editor#1112's elevator and roof changes into independently validated fork-local units.

Implemented by ChatGPT (mobile app, GitHub connector) for Kevin's OSS factory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants