Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Upstream #1112 leaves lean-to managed posts movable in 3D: a
nulloverride falls back to the base X/Z axes. The fork'smainlikewise had no managed-column movement override. Its 2D column move session also needed a corresponding no-commit guard. The upstream PR is a conflicting 167-file change set with a stale assertion thatnullis the intended managed override.Design
Selectively reconcile the reviewed upstream head
c3edd17a82b2c5c44942ef2da83cb24a0b734d82with forkmain352ec93ccefa7155e60f7b9cfc6fd04c4e1b1bac: retain only the managed-post movement fix and colocated observable regressions. The branch starts at the reviewed upstream PR head; its one two-parent reconciliation commit includes currentmainand a narrow replacement tree. GitHub comparison againstmainchanges only three column files. This is not a linear rebase or a claim that all 167 upstream files were ported.movable.override; 2D move checks the same registry capability.Change (at
3e15eb237ab26c7a321ecd254aaa6a2c1c266832)packages/nodes/src/column/definition.ts:403-410— return{ axes: [] }for lean-to managed posts; preserve normal X/Z fallback for unmanaged columns.packages/nodes/src/column/floorplan-move.ts:38-42— managed 2D sessions have no affected nodes and cannot commit.packages/nodes/src/column/definition.test.ts:42-99— three exported-behavior regressions for managed vertical, managed K-brace, and unmanaged posts; the upstream staletoBeNull()assertion was intentionally not carried into this focused split.Tests
All UNRUN by this GitHub-connector worker; no browser, Bun or Biome execution:
Hand-worked with grid snap disabled from the checked-in
resolveMovable,moveTowardandmovePlanTowardcontracts:[0, 0.3, 0]→[1, 4, 2](3D)[1, 0.3, 2][0, 0.3, 0][2, 1]→[2.5, 3][2.5, 3][2, 1]; actual plan session cannot commit[0, 0.3, 0]→[1, 4, 2][1, 0.3, 2][1, 0.3, 2][0, 0]→[1, 2][1, 2][1, 2]These are mathematical expectations, not executed test results. GitHub compare: only three column files;
mainis in the new commit's ancestry, no default-branch updates.Upstream readiness
HOLD. This is a downstream fork-only Draft PR. Upstream pascalorg#1112 is open with requested changes, and its broader pillar/elevator/roof work still requires independent review and runtime visual validation. The branch preserves upstream history (8 commits ahead despite a 3-file diff); consider clean linear history when review-ready. No upstream actions or merges.
Follow-ups
Implemented by ChatGPT (mobile app, GitHub connector) for Kevin's OSS factory.