Skip to content

fix(nodes/core): roof-host re-snap, dirty notification, and port facing (#1125) - #41

Draft
kvnloo wants to merge 10 commits into
mainfrom
nc/pe25-1125-port-geometry
Draft

kvnloo wants to merge 10 commits into
mainfrom
nc/pe25-1125-port-geometry

Conversation

@kvnloo

@kvnloo kvnloo commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

Problem

The reviewed upstream PR #1125 introduces HVAC physical port classification and roof accessories, but its inherited branch has two reported roof placement regressions: placing a box vent does not explicitly dirty the host roof segment, and the box-vent/chimney placement tools use the original hit segment after snapping. The earlier PE25 port-geometry card addressed the separate physical port-facing regression.

Design

  • PE31 (E-003/T-001): Preserve the synthetic pre-change scene as an in-repo behavior fixture (same bytes) and test through public @pascal-app/core exports. Exclude review-only media from distributed source. Keep contributor history intact while deferring unsafe 3-way code integration.

  • Port geometry (PE25): Keep profile-only connectionCompatibility unchanged; require opposed, non-zero direction vectors before portConnection reports a physical match or adapter.

  • Roof host (PE26): Project a snapped target into world coordinates, resolve the actual roof segment, then transform back into that segment's local frame. Box-vent and chimney preview, guides, validity, parenting and commit consistently use that resolved host; the placed box vent explicitly calls sceneApi.markDirty(host.id).

  • Respects E-001 (scene logic in existing core/nodes/editor boundaries, no runtime Three in core), E-002/E-017 (registered node definitions and tool API, no plugin manifest change), E-003 (no schema/scene migration), E-006 (the existing roof-event 3D placement path; no new 2D interaction), E-010 (existing host/dirtiness and agent mechanisms are reused) and T-001 (observable Bun regressions via existing public tool/context and core exports).

Change

PE31 reconciliation child commit 9120bf45b3e6, parent 4a83d71911c343e5ac2012747ada61849f090f1f:

  • packages/core/src/schema/legacy-roof-hvac-scene.test.ts:1-64: exported @pascal-app/core load/resave regression, checking eight original node identities, hierarchy, box-vent dimensions, HVAC port sizes and suction-line geometry.
  • packages/core/src/schema/__fixtures__/legacy-roof-hvac-scene.json:1-232: original legacy-scene JSON moved without altering its blob (b9f2752857847c9f03d04d7bb323fd8160a42d91).
  • Deleted the complete eight-file review-only wiki/design/pr-1125-verification/ folder (README, six WebP screenshots, source JSON). No runtime code or contributor commits were rewritten.
  • Partial reconciliation only: no merge/rebase of the 83 newer main commits; no manual conflict resolution or reference-inventory extraction is claimed.

Fork-only branch nc/pe25-1125-port-geometry has three follow-up commits atop the inherited upstream contributor head b7dae4c4b9387888301ed71de4447d2196d83c1b; no upstream changes are claimed.

PE26 commit 4a83d71911c3, parent 01812af5a2ad059d962dfcccf4dbe29dc1e20cda:

PE25 parent commit 01812af5a2ad:

Tests

UNRUN — connector-only editing; no Bun, Biome, types or local editor walkthrough was executed:

bun test packages/core/src/schema/legacy-roof-hvac-scene.test.ts
bun run test --filter=@pascal-app/nodes
bun run test --filter=@pascal-app/editor
bun run check
bun run check-types
bun run ci

New PE26 behavioral test: source roof segment is 8 m wide (±4 m, zero deck reach), second segment's origin is world X = 7 m. Pointer X = 3.95 m, grid step 1.1 m gives round(3.95 / 1.1) * 1.1 = 4.4 m, outside the source, inside the second segment; its local X is 4.4 − 7 = −2.6 m, Z stays 1.1 m. Both box-vent and chimney preview and commit must select that second host and explicitly notify it as dirty. The existing unsnapped box-vent test now separately checks the host dirty call. The PE25 tests cover inclusive 5 cm proximity, opposed vs parallel 8″/10″ ports (diameter delta 2″ > 0.001″) and zero direction.

Fork Actions check at this SHA: no workflow run reported yet; no CI pass asserted. Tests and interactive roof rebuild remain unverified.

Upstream readiness

HOLD; no green checks and no merge claim. This is fork-only Draft PR #41, head 9120bf45b3e606eb88bcc54ec9b9171be79ade2c, into fork main at 352ec93ccefa7155e60f7b9cfc6fd04c4e1b1bac. The current PR contains 274 files versus main and reports mergeable=false; exact 3-way tree inspection shows 83 newer main commits and 23 paths independently modified on both sides. Several intersections are semantic (existing i18n vs contributor inspector style controls), not safely resolved by copying one side. No merge parents or default-branch changes were added.

The original contributor sudhir9297 and the full upstream #1125 contribution remain in the branch ancestry. The unrelated architect request reference-inventory metadata classification added in the inherited commit b7dae4c4 is named explicitly, not silently dropped. Current main has its own request-metadata inventory entries alongside more recent asset/reference rules. Safe extraction requires reconciling those rules against the newer schema; it was not performed in the one permitted child commit.

CI: not run for the new head when checked; no Bun, Biome, typechecking or browser proof has been executed or claimed. The new compatibility test is UNRUN. PE25/PE26 regressions are also UNRUN.

Follow-ups

  1. PE32-1125-MAIN-RECONCILE — authorize a dedicated fork-only integration on this existing Draft branch, 3-way merge all 23 independently edited paths (particularly translated inspector controls), preserve both feature sets and contributor history, then re-check exact-head mergeability.
  2. PE32-1125-INVENTORY-SPLIT — isolate the architect request metadata fix from b7dae4c4 by comparing with the version already on current main; remove duplication only after the integration keeps HVAC face declarations and current reference policies correct.
  3. PE32-1125-EXACT-HEAD-VERIFY — build core/viewer/editor/nodes, run the exported old-scene, roof-host and port-geometry Bun regressions, Biome/types/full CI and mounted scene-load/rebuild walkthrough. Record observed checks and link the run; do not infer passing status.

Implemented by ChatGPT (mobile app, GitHub connector) for Kevin's OSS factory.

@kvnloo kvnloo changed the title fix(core): check physical port facing before suggesting adapters (#1125 follow-up) fix(nodes/core): roof-host re-snap, dirty notification, and port facing (#1125) Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants