chore: Decouple controller runtime from api go module#2724
Closed
ruanxin wants to merge 6 commits intokyma-project:mainfrom
Closed
chore: Decouple controller runtime from api go module#2724ruanxin wants to merge 6 commits intokyma-project:mainfrom
ruanxin wants to merge 6 commits intokyma-project:mainfrom
Conversation
… finalizer management - Introduced a new service `kymaService` in the Reconciler to handle label and finalizer logic. - Updated the `EnsureLabelsAndFinalizers` method to be part of the new service. - Adjusted the Reconcile method to call the new service for label and finalizer updates. - Added a new file for the `kymaService` implementation. Update test files to use the new API scheme - Replaced direct calls to `v1beta2.AddToScheme` with `api.AddToScheme` in multiple test files. - Ensured consistency across tests by using the new API scheme management. Refactor imports in various test files - Removed unnecessary imports of the old API package and replaced them with the new unified API package. - Cleaned up import statements across multiple test files for better organization and clarity.
ruanxin
changed the title
Contributor
|
❌ Manifests created with 'make dry-run-control-plane' changed! Please make sure to check if changes are needed in related repositories like management-plane-charts, runtime-watcher, etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
kymaServicein the Reconciler to handle label and finalizer logic.EnsureLabelsAndFinalizersmethod to be part of the new service.kymaServiceimplementation.Update test files to use the new API scheme
v1beta2.AddToSchemewithapi.AddToSchemein multiple test files.Refactor imports in various test files
Related issue(s)