Skip to content

chore: Fix skipping sec-scanners-config.yaml bump #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
c-pius merged 4 commits into from
Mar 6, 2026
Merged

chore: Fix skipping sec-scanners-config.yaml bump #701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
874450e
chore: Fix skipping sec-scanners-config.yaml bump
c-pius Mar 5, 2026
415fc40
Merge branch 'main' into chore/fix-skipping-sec-scanners-bump
c-pius Mar 6, 2026
0162627
add nounset to create_changelog.sh; drop ref:main from workflow
c-pius Mar 6, 2026
bfcf293
use correct input number
c-pius Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/scripts/release/create_changelog.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
#!/usr/bin/env bash


set -o nounset
set -o errexit
set -E
set -o pipefail

CURRENT_RELEASE_TAG=$1
DOCKER_IMAGE_URL=$2
LAST_RELEASE_TAG=$3
LAST_RELEASE_TAG=${3:-} # default to empty string if not provided so that "nounset" doesn't cause an error

if [ "${LAST_RELEASE_TAG}" == "" ]
then
Expand Down
12 changes: 10 additions & 2 deletions .github/workflows/create-runtime-watcher-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,17 @@ jobs:
name: Create draft release
runs-on: ubuntu-latest
needs: [validate-release, await-bump-images-pr-merge]
if: |
always() &&
needs.validate-release.result == 'success' &&
(needs.await-bump-images-pr-merge.result == 'success' || needs.await-bump-images-pr-merge.result == 'skipped')
permissions:
contents: write
steps:
- name: Checkout code
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
fetch-depth: 0
ref: main # Checkout main after version bump PR is merged
- name: Generate changelog
id: generate_changelog
env:
Expand All @@ -138,6 +141,8 @@ jobs:
release_id: ${{ steps.draft-release.outputs.release_id }}
builds:
needs: draft-release
# the always() is needed so that the job is not skipped if previous jobs were skipped due to skip_sec_scanners_bump
if: always() && needs.draft-release.result == 'success'
uses: ./.github/workflows/build-image.yml
with:
tag: "${{ github.event.inputs.name }}"
Expand All @@ -146,7 +151,10 @@ jobs:
id-token: write
publish_release:
name: Publish release
needs: [validate-release, draft-release, builds]
needs: [draft-release, builds]
# the always() is needed so that the job is not skipped if previous jobs were skipped due to skip_sec_scanners_bump
# draft-release is needed as we use needs.draft-release.outputs.release_id below
if: always() && needs.builds.result == 'success' && needs.draft-release.result == 'success'
runs-on: ubuntu-latest
permissions:
contents: write
Expand Down
Loading