Skip to content

Wagtail 7.2 maintenance#257

Open
nickmoreton wants to merge 38 commits intolabd:masterfrom
torchbox-forks:wagtail-72-maintenance
Open

Wagtail 7.2 maintenance#257
nickmoreton wants to merge 38 commits intolabd:masterfrom
torchbox-forks:wagtail-72-maintenance

Conversation

@nickmoreton
Copy link
Contributor

@nickmoreton nickmoreton commented Nov 26, 2025

Passing on some changes we've been making on our local fork.

The last piece of work is to add testing for Wagtail 7.2 and Python 3.14

katdom13 and others added 30 commits February 28, 2024 15:47
…ister_user_listing_buttons hook was updated to accept a request_user argument instead of context
Update readme with fork information
- Allow Django 5.1
- Drop Django 3.2
- Add Python 3.13
- Drop Python 3.8
- Add Wagtail 6.3
- Drop Wagtail 6.1
- Drop Wagtail 6.0
We're only supporting Django >=4.2 now
@nickmoreton nickmoreton marked this pull request as ready for review November 26, 2025 10:45
{% if user_id == request.user.id %}
<a href="{% url 'wagtail_2fa_device_new' %}" class="button bicolor icon icon-plus">{% trans 'New device' %}</a>
<a href="{% url 'wagtail_2fa_device_new' %}" class="button bicolor button--icon">
<span class="icon-wrapper"><svg class="icon icon-plus icon" aria-hidden="true"><use href="#icon-plus"></use></svg></span>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: use the {% icon %} tag (https://docs.wagtail.org/en/stable/advanced_topics/icons.html#icon-template-tag)

Suggested change
<span class="icon-wrapper"><svg class="icon icon-plus icon" aria-hidden="true"><use href="#icon-plus"></use></svg></span>
{% icon name="plus" wrapped=1 %}

with {% load wagtailadmin_tags %}

if WAGTAIL_VERSION >= (7, 1):
from wagtail.admin.widgets import Button
else:
from wagtail.users.widgets import UserListingButton
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion:

Suggested change
from wagtail.users.widgets import UserListingButton
from wagtail.users.widgets import UserListingButton as Button

then register_user_listing_buttons doesn't need the conditional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants