Merged
Conversation
Signed-off-by: Tomas Novotny <tomas@novotny.cz>
Update helpers to enforce a maximum interface name length of 15 characters, matching the actual limit. In Linux, the last byte of the 16-byte array is reserved for the null terminator. Signed-off-by: Tomas Novotny <tomas@novotny.cz>
The helpers with sudo on exporters cannot be used together with systemd's DynamicUser. This directive enforces the NoNewPrivileges directive, which leads to the following error: sudo: The "no new privileges" flag is set, which prevents sudo from running as root. sudo: If sudo is running in a container, you may need to adjust the container configuration to disable the flag. Since DynamicUser introduced in 0a2deef ("contrib/systemd/labgrid-exporter: improve service") is a useful feature, switch to User and Group only when using helpers. Signed-off-by: Tomas Novotny <tomas@novotny.cz>
Emantor
approved these changes
Jan 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1794 +/- ##
======================================
Coverage 45.1% 45.1%
======================================
Files 172 172
Lines 13617 13617
======================================
Hits 6143 6143
Misses 7474 7474
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor updates to the helpers and doc. These were found when working on a new helper in #1719 -- especially the sudo and
DynamicUserlimitation. I didn't test the helpers which are in the current master (though I thinklabgrid-raw-interfaceis also affected when used on the exporter).I've regenerated the doc with no issues.