feat(FR-1720): implement theme color reset functionality#4785
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 18, 2025
Merged
feat(FR-1720): implement theme color reset functionality#4785graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
ironAiken2
force-pushed
the
feat/FR-1720-theme-color-reset
branch
from
bdbf13c to
9172c62
Compare
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.36% | 516/11835 |
| 🔴 | Branches | 3.58% | 298/8319 |
| 🔴 | Functions | 2.62% | 95/3629 |
| 🔴 | Lines | 4.34% | 502/11577 |
Test suite run success
145 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 0695326
ironAiken2
requested review from
Copilot,
nowgnuesLee and
yomybaby
and removed request for
Copilot
nowgnuesLee
requested changes
Dec 8, 2025
ironAiken2
force-pushed
the
feat/FR-1720-theme-color-reset
branch
from
9172c62 to
ebcdf6a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements individual theme color reset functionality, allowing users to reset specific theme color tokens to their defaults. Key changes include adding functional update support to useBAISettingUserState to prevent race conditions during bulk resets, refactoring the settings component architecture to use onAfterChange instead of onChange, and introducing per-item reset buttons with confirmation modals.
- Added
resetThemeConfigfunction to reset individual theme colors back to default values from theme.json - Refactored setting items to use
checkboxProps/selectPropsinstead of top-leveldisabledprop for better type safety - Implemented functional update pattern in atom setter to support safe state updates
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| react/src/hooks/useBAISetting.tsx | Added functional update support (SetStateAction<T>) to useBAISettingUserState to enable safe state updates and prevent race conditions |
| react/src/components/BrandingSettingList.tsx | Implemented resetThemeConfig function to reset individual theme tokens using functional updates |
| react/src/components/SettingItem.tsx | Added individual reset button UI with dropdown menu, confirmation modal, and refactored to use checkboxProps/selectProps |
| react/src/components/SettingList.tsx | Updated resetSettingItems to support custom onReset handlers and refactored validation logic for new prop structure |
| react/src/pages/UserSettingsPage.tsx | Migrated from onChange to onAfterChange pattern and added showResetButton: false for non-resettable config buttons |
| react/src/components/ConfigurationsSettingList.tsx | Refactored disabled prop to use checkboxProps.disabled structure, removed global reset button |
| react/src/components/MaintenanceSettingList.tsx | Added showResetButton: false to maintenance action buttons |
| react/src/components/BrandingSettingItems/ThemeColorPicker.tsx | Exported ThemeConfigPath type for use in reset functionality |
ironAiken2
force-pushed
the
feat/FR-1720-theme-color-reset
branch
from
ebcdf6a to
0755d8e
Compare
nowgnuesLee
requested changes
Dec 9, 2025
Contributor
nowgnuesLee
left a comment
nowgnuesLee
left a comment
There was a problem hiding this comment.
Could you review the copilot's reviews?
ironAiken2
force-pushed
the
feat/FR-1720-theme-color-reset
branch
from
0755d8e to
a9a7a71
Compare
5 tasks
ironAiken2
force-pushed
the
feat/FR-1720-theme-color-reset
branch
from
a9a7a71 to
9bc0ecd
Compare
yomybaby
force-pushed
the
feat/FR-1720-theme-color-reset
branch
from
9bc0ecd to
a9a7a71
Compare
Merge activity
|
Resolves #4689 ([FR-1720](https://lablup.atlassian.net/browse/FR-1720)) ## Summary - Add `resetThemeConfig` function to reset individual theme color tokens back to their default values - Support functional updates in `useBAISettingUserState` to prevent race conditions during bulk resets - Fix theme color reset functionality to properly restore default theme.json values ## Test plan - [ ] Verify individual theme color reset works correctly for each color picker - [ ] Verify "Reset All" button properly resets all theme colors at once - [ ] Confirm reset values match the default theme.json configuration [FR-1720]: https://lablup.atlassian.net/browse/FR-1720?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
graphite-app
bot
force-pushed
the
feat/FR-1720-theme-color-reset
branch
from
a9a7a71 to
0695326
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4689 (FR-1720)
Summary
resetThemeConfigfunction to reset individual theme color tokens back to their default valuesuseBAISettingUserStateto prevent race conditions during bulk resetsTest plan