fix(FR-1784): Replace popconfirm with Modal for image deletion#4809
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 12, 2025
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.37% | 517/11820 |
| 🔴 | Branches | 3.58% | 298/8316 |
| 🔴 | Functions | 2.63% | 95/3618 |
| 🔴 | Lines | 4.35% | 503/11560 |
Test suite run success
145 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 4f95d60
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a logic error in the delete button's disabled state for customized images in the MyEnvironment page. The button was incorrectly enabled for the row being deleted and disabled for all other rows, when it should have been the opposite.
Key Changes:
- Corrected the disabled condition from
!==to===to properly disable the button for the row currently being deleted
nowgnuesLee
force-pushed
the
fix/crrect-logic-for-disabling-delete-button-in-myenvironment-page
branch
from
1266cfb to
c8568ac
Compare
nowgnuesLee
changed the title
ironAiken2
previously requested changes
Dec 12, 2025
Contributor
ironAiken2
left a comment
ironAiken2
left a comment
There was a problem hiding this comment.
I left some comments :)
yomybaby
force-pushed
the
fix/crrect-logic-for-disabling-delete-button-in-myenvironment-page
branch
from
c8568ac to
c90286f
Compare
Merge activity
|
resolves #4807 ([FR-1784](https://lablup.atlassian.net/browse/FR-1784)) This PR replaces the Popconfirm component with a BAIModal for deleting customized images in the CustomizedImageList component. The change improves the user experience by: 1. Using a proper modal dialog with an Alert component to warn users about the irreversible action 2. Improving the deletion flow by centralizing the deletion logic in the modal 3. Removing the `inFlightImageId` state in favor of tracking the image to delete with a dedicated state variable 4. Properly handling loading states during the deletion process **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after [FR-1784]: https://lablup.atlassian.net/browse/FR-1784?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
graphite-app
bot
force-pushed
the
fix/crrect-logic-for-disabling-delete-button-in-myenvironment-page
branch
from
c90286f to
4f95d60
Compare
graphite-app
bot
deleted the
fix/crrect-logic-for-disabling-delete-button-in-myenvironment-page
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #4807 (FR-1784)
This PR replaces the Popconfirm component with a BAIModal for deleting customized images in the CustomizedImageList component. The change improves the user experience by:
inFlightImageIdstate in favor of tracking the image to delete with a dedicated state variableChecklist: