fix(FR-1807): use fixed height for LazyLog container in ContainerLogModal#4872
Closed
ironAiken2 wants to merge 1 commit intomainfrom
Closed
fix(FR-1807): use fixed height for LazyLog container in ContainerLogModal#4872ironAiken2 wants to merge 1 commit intomainfrom
ironAiken2 wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
ironAiken2
requested review from
Copilot,
nowgnuesLee and
yomybaby
and removed request for
Copilot
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.24% | 496/11686 |
| 🔴 | Branches | 3.66% | 298/8147 |
| 🔴 | Functions | 2.56% | 92/3590 |
| 🔴 | Lines | 4.22% | 482/11430 |
Test suite run success
144 tests passing in 13 suites.
Report generated by 🧪jest coverage report action from 4b62fb0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4871 (FR-1807)
Summary
Details
This change addresses a potential timing issue where
calc()CSS values may not be resolved when LazyLog reads the container height.As reported in melloware/react-logviewer#36, the LazyLog component can encounter infinite loop or "Maximum update depth exceeded" errors when its parent container doesn't have a properly defined height at the time of initialization. The
calc(100% - 50px)expression may not be computed in time for LazyLog to correctly read the container dimensions, leading to unexpected behavior.By using a fixed
100%height instead of a calculated value, we ensure the container has a stable height that LazyLog can reliably read during its initialization phase.Test plan