Skip to content

fix(FR-621): add ssl_verify checkbox to Container Registry Editor Modal#7354

Merged
graphite-app[bot] merged 1 commit into
mainfrom
05-11-fix_fr-621_add_ssl_verify_checkbox_to_container_registry_editor_modal
May 12, 2026
Merged

fix(FR-621): add ssl_verify checkbox to Container Registry Editor Modal#7354
graphite-app[bot] merged 1 commit into
mainfrom
05-11-fix_fr-621_add_ssl_verify_checkbox_to_container_registry_editor_modal

Conversation

@yomybaby
Copy link
Copy Markdown
Member

@yomybaby yomybaby commented May 11, 2026

Resolves #3302(FR-621)

Summary

The ssl_verify field is exposed in the GraphQL schema (V2 create/modify inputs) and the Container Registry fragment already selects it, but the Add/Modify modal had no UI control to set it. Customers running in-house registries with self-signed or private certificates could not disable SSL verification through the WebUI, which blocked registry registration and image pulls.

Changes

  • Add ssl_verify checkbox to ContainerRegistryEditorModal (placed just above the is_global field).
  • Wire ssl_verify into form initialValues for both create and modify paths, defaulting to true (verification enabled — safer default).
  • Send ssl_verify in both create and modify mutation variables.
  • Add i18n keys registry.SSLVerify and registry.SSLVerifyDescription to en.json. Other locales will be handled via /fw:i18n.

Review feedback applied

  • Display semantics: Legacy rows with null ssl_verify now display the checkbox as unchecked. This matches the backend runtime, which treats null the same as false and disables SSL verification (container_registry/base.py:117if not self.registry_info.ssl_verify: ssl_ctx = False). The previous ?? true default visually misrepresented these legacy registries as having SSL verification enabled. Create-path default remains true.
  • Copy update: i18n label changed from "SSL Verification""Verify SSL Certificate", and description changed from "Verify SSL certificate when connecting to this registry""Disable only for registries with self-signed or private certificates." to match the action-statement + behavior-clarifier pattern used by the adjacent IsGlobal field.

Files changed

  • react/src/components/ContainerRegistryEditorModal.tsx
  • resources/i18n/en.json

Verification

  • bash scripts/verify.sh — Relay PASS, Lint PASS, Format PASS. The TypeScript failures reported are pre-existing on main (in packages/backend.ai-client/src/client.ts and react/src/components/DeleteForeverVFolderModalV2.tsx) and unrelated to this change.

Screenshots

Add Registry modal — new "Verify SSL Certificate" checkbox

Add Registry modal

Modify Registry modal — reflects current DB state (checked when ssl_verify === true)

Modify Registry modal

Copilot AI review requested due to automatic review settings May 11, 2026 22:52
Copy link
Copy Markdown
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a UI control to configure SSL certificate verification for container registries, wiring the new ssl_verify value through the Container Registry Editor modal’s form initialization and create/modify mutations.

Changes:

  • Add ssl_verify to the registry editor form model, initial values, and mutation variables.
  • Add an “SSL Verification” checkbox to the Container Registry Editor modal UI.
  • Introduce new i18n strings for the checkbox label/description (currently English only).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
resources/i18n/en.json Adds English translation keys for the new SSL verification checkbox.
react/src/components/ContainerRegistryEditorModal.tsx Adds ssl_verify field to the form, initializes it, and submits it in create/modify mutations with a new checkbox UI.

Comment thread resources/i18n/en.json
@github-actions github-actions Bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels May 11, 2026
yomybaby added a commit that referenced this pull request May 12, 2026
yomybaby added a commit that referenced this pull request May 12, 2026
Copy link
Copy Markdown
Contributor

@nowgnuesLee nowgnuesLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 12, 2026

Merge activity

…al (#7354)

Resolves #3302(FR-621)

## Summary

The `ssl_verify` field is exposed in the GraphQL schema (V2 create/modify inputs) and the Container Registry fragment already selects it, but the Add/Modify modal had no UI control to set it. Customers running in-house registries with self-signed or private certificates could not disable SSL verification through the WebUI, which blocked registry registration and image pulls.

## Changes

- Add `ssl_verify` checkbox to `ContainerRegistryEditorModal` (placed just above the `is_global` field).
- Wire `ssl_verify` into form `initialValues` for both create and modify paths, defaulting to `true` (verification enabled — safer default).
- Send `ssl_verify` in both create and modify mutation variables.
- Add i18n keys `registry.SSLVerify` and `registry.SSLVerifyDescription` to `en.json`. Other locales will be handled via `/fw:i18n`.

## Review feedback applied

- **Display semantics**: Legacy rows with `null` `ssl_verify` now display the checkbox as **unchecked**. This matches the backend runtime, which treats `null` the same as `false` and disables SSL verification (`container_registry/base.py:117` — `if not self.registry_info.ssl_verify: ssl_ctx = False`). The previous `?? true` default visually misrepresented these legacy registries as having SSL verification enabled. Create-path default remains `true`.
- **Copy update**: i18n label changed from `"SSL Verification"` → `"Verify SSL Certificate"`, and description changed from `"Verify SSL certificate when connecting to this registry"` → `"Disable only for registries with self-signed or private certificates."` to match the action-statement + behavior-clarifier pattern used by the adjacent `IsGlobal` field.

## Files changed

- `react/src/components/ContainerRegistryEditorModal.tsx`
- `resources/i18n/en.json`

## Verification

- `bash scripts/verify.sh` — Relay PASS, Lint PASS, Format PASS. The TypeScript failures reported are pre-existing on `main` (in `packages/backend.ai-client/src/client.ts` and `react/src/components/DeleteForeverVFolderModalV2.tsx`) and unrelated to this change.

## Screenshots

**Add Registry modal — new "Verify SSL Certificate" checkbox**

![Add Registry modal](https://raw.githubusercontent.com/lablup/backend.ai-webui/assets/images/screenshots/pr-7354/20260512-000825-ssl-verify-add-modal.png)

**Modify Registry modal — reflects current DB state (checked when `ssl_verify === true`)**

![Modify Registry modal](https://raw.githubusercontent.com/lablup/backend.ai-webui/assets/images/screenshots/pr-7354/20260512-000825-ssl-verify-modify-modal.png)
@graphite-app graphite-app Bot force-pushed the 05-11-fix_fr-621_add_ssl_verify_checkbox_to_container_registry_editor_modal branch from 42996c6 to 4ff04e7 Compare May 12, 2026 01:27
@graphite-app graphite-app Bot merged commit 4ff04e7 into main May 12, 2026
11 of 12 checks passed
@graphite-app graphite-app Bot deleted the 05-11-fix_fr-621_add_ssl_verify_checkbox_to_container_registry_editor_modal branch May 12, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:ux UI / UX issue. size:M 30~100 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing ssl_verify inputbox on container registry update modal window

3 participants