Conversation
Contributor
|
⏳ Processing in progress |
Preview sandbox Image: |
Preview mcp_server Image: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors OpenAPI-related type definitions and documentation to improve consistency and clarity. The changes primarily reorganize schema locations, improve Zod schema composition patterns, and enhance API endpoint documentation.
Key changes:
- Moved presign chat file schemas from
packages/global/core/chat/api.tstopackages/global/openapi/core/chat/api.tsfor better organization - Refactored Zod schema composition from
.and()to more idiomatic.extend()pattern - Corrected OpenAPI endpoint definitions for presign URLs (schemas and descriptions were swapped)
- Enhanced API documentation with role-based prefixes (e.g., "应用管理员-") to distinguish admin operations
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
projects/app/src/pages/api/core/chat/presignChatFilePostUrl.ts |
Updated import path to reflect new schema location |
projects/app/src/pages/api/core/chat/presignChatFileGetUrl.ts |
Updated import path to reflect new schema location |
packages/global/support/permission/chat.ts |
Refactored OutLinkChatAuthSchema to use .extend() instead of .and() for better schema composition |
packages/global/openapi/core/chat/index.ts |
Fixed swapped endpoint definitions and corrected their schemas, summaries, and response types |
packages/global/openapi/core/chat/history/api.ts |
Refactored schema composition from nested .and() to cleaner .extend() pattern |
packages/global/openapi/core/chat/feedback/index.ts |
Reorganized endpoints in logical order and added role-based prefixes to admin operations |
packages/global/openapi/core/chat/api.ts |
New file containing presign URL schemas with improved field descriptions |
packages/global/openapi/api.ts |
Added descriptions to pagination schema fields |
packages/global/core/chat/api.ts |
Deleted file - schemas moved to openapi directory |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Preview fastgpt Image: |
Docs Preview:🚀 FastGPT Document Preview Ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.