Conversation
Contributor
TestGru AssignmentSummary
Tip You can |
Preview sandbox Image: |
Preview mcp_server Image: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the ticket access logic by implementing a fallback mechanism for determining ticketResponseTime. Previously, the logic only checked the team's subscription for the ticketResponseTime value, which could be undefined even when the plan includes ticket support. The fix ensures that if the team's subscription doesn't have an explicit ticketResponseTime, it falls back to the default value from the subscription plan configuration.
- Updated ticket access check to fall back to plan's default
ticketResponseTimewhen not set on team subscription - Cleaned up unused import in WorkorderEntrance component
- Enhanced S3 error handling to include additional error message pattern
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| projects/app/src/pages/account/info/index.tsx | Added TeamErrEnum import and refactored feedback handler to check ticket access with fallback logic before opening workorder |
| projects/app/src/pageComponents/chat/WorkorderEntrance.tsx | Removed unused getWorkorderURL import |
| projects/app/src/components/Layout/HelperBot.tsx | Updated hasTicketAccess logic with fallback to plan's ticketResponseTime and added subPlans to dependencies |
| packages/service/common/s3/buckets/base.ts | Added new error message pattern for bad components in resource names to file not found check |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Preview fastgpt Image: |
newfish-cmyk
pushed a commit
to newfish-cmyk/FastGPT
that referenced
this pull request
Dec 22, 2025
* stop design doc * remove invalid doc * del s3 tip * fix: ticktime * fix: ticktime * fix: ticktime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.