Conversation
|
|
|
c79c8f9 to
d9c961f
Compare
|
this test runner was removed PR now contains ways to specify the command, function source, and site_url if you need to test the action with your self hosted instance of Lagon ./test.sh -r lagonapp/github-action@my-dev-branch \
-f ~/Projects/lagon-function \
-c "ls" \
-s "https://lagon.mysite.io"at a minimum you just need to pass a function ./test.sh -f ~/Projects/lagon-function |
d6b0b6d to
8586752
Compare
QuiiBz
left a comment
There was a problem hiding this comment.
Thanks a lot for your help on this!
9af4473 to
70ff752
Compare
9f6fdfd to
7744eea
Compare
97a07b0 to
bb4a028
Compare
|
Ok, action should be merge-able now. Lots of real testing. I have added support for passing in a config object which will override the functions existing one or useful if you never committed one. Also, another important part I almost forgot. This action allows you to run any CLI command right ? Well that is so you can than perform other steps like maybe send an email of a preview link to your function in a slack channel or something. I have achieved this by saving the CLI output to a local file called here is an example of the action being used in a workflow to deploy a function than log the preview. You can see the workflow for this here. here is an example of what the action does if the CLI errors. I encountered lagonapp/lagon#696 which made the action really difficult to exit correctly but I found a decent enough workaround but it's very brittle.... |
|
lagonapp/lagon#697 was just posted. I'll get the action working with that once it's merged. |
Signed-off-by: 20k-ultra <3946250+20k-ultra@users.noreply.github.com>
|
good to go @QuiiBz! I've done a good amount of manual testing (actually running the action and making sure it errors when I wanted it to). I'm confident we can merge this and add more features as people want but the way it's built, it will be flexible enough to do anything you can normally do with local cli installation. Photo of the action using the example from the readme but I have another step that reads the |
QuiiBz
left a comment
There was a problem hiding this comment.
Thank you so much for this work!

This is pretty complete and I expect to actually work. I just don't have local instance setup to confirm but it's pretty trivial what's going on..
The developing section needs 1 more piece to actually pass a folder containing a function.good to merge if someone can confirm via running the test.sh with valid api tokens since I don't have local Lagon instance setup yet.