Remove using namespace directive in a header#133
Open
nedseb wants to merge 1 commit intolancaster-university:masterfrom
Open
Remove using namespace directive in a header#133nedseb wants to merge 1 commit intolancaster-university:masterfrom
using namespace directive in a header#133nedseb wants to merge 1 commit intolancaster-university:masterfrom
Conversation
A `using namespace` inside a header makes useless namespace so it should be removed.
Contributor
|
Thanks @nedseb. I agree that this using directive shouldn't be here. I seem to recall that it was a "quick fix" necessary to support transparency for microbit-v2 (out biggest user). I think there are also other directives like this in other .h files that we should remove at the same time. Doing so will require us to ensure that we don't introduce incompatibilities though... |
Contributor
Author
|
Yes, I understand.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
using namespaceinside a header makes useless namespace so it should be removed.