fix(core): prevent memory leak from lru_cache on bound methods#35296
Open
yaowubarbara wants to merge 1 commit intolangchain-ai:masterfrom
Open
fix(core): prevent memory leak from lru_cache on bound methods#35296yaowubarbara wants to merge 1 commit intolangchain-ai:masterfrom
yaowubarbara wants to merge 1 commit intolangchain-ai:masterfrom
Conversation
Skip lru_cache for bound methods in get_function_nonlocals to avoid holding strong references that prevent garbage collection.
yaowubarbara
requested a review
from Eugene Yurtsev (eyurtsev)
as a code owner
github-actions
bot
added
external
core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@lru_cacheonget_function_nonlocalsholds strong references to bound method arguments, preventing the associated objects from being garbage collectedinspect.ismethod) and a cached path for regular functions/lambdaslru_cacheperformance, bound methods just compute directly (they never had cache hits anyway since eachobj.methodcreates a new method object)Fixes #30667
Test plan
test_bound_method_no_memory_leak— verifiesget_function_nonlocals(obj.call)does not preventobjfrom being garbage collectedtest_bound_method_in_runnable_sequence_no_leak— verifies the full(thing.call | RunnablePassthrough()).invoke({})scenario does not leaktest_nonlocalsstill passes (regular functions and lambdas still cached correctly)