Skip to content

Comments

feat(core): forward bound kwargs in RunnableBinding.__getattr__#35322

Open
Mohammad Mohtashim (keenborder786) wants to merge 3 commits intolangchain-ai:masterfrom
keenborder786:mmk/bound_parameters
Open

feat(core): forward bound kwargs in RunnableBinding.__getattr__#35322
Mohammad Mohtashim (keenborder786) wants to merge 3 commits intolangchain-ai:masterfrom
keenborder786:mmk/bound_parameters

Conversation

@keenborder786
Copy link
Contributor

  • RunnableBinding.getattr now forwards bound kwargs to delegated methods that accept **kwargs.
  • Previously, only bound config was passed to the underlying runnable's methods. Now, bound kwargs are also forwarded to methods with **kwargs, with explicit kwargs taking precedence.
runnable.bind(foo="bar").some_method(baz="qux")
# some_method receives: foo="bar", baz="qux"

Use case was identified in #35320

@github-actions github-actions bot added core `langchain-core` package issues & PRs external feature For PRs that implement a new feature; NOT A FEATURE REQUEST labels Feb 19, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 20, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 13 untouched benchmarks
⏩ 22 skipped benchmarks1


Comparing keenborder786:mmk/bound_parameters (dc42e89) with master (4af87fd)2

Open in CodSpeed

Footnotes

  1. 22 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on master (135a208) during the generation of this report, so 4af87fd was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core `langchain-core` package issues & PRs external feature For PRs that implement a new feature; NOT A FEATURE REQUEST

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant