Skip to content

Conversation

@laipz8200
Copy link
Member

@laipz8200 laipz8200 commented Jan 4, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

  • Part of Minimal DI for workflow nodes via node_factory constructor injection #30506
  • Introduce a Jinja2 template renderer abstraction for TemplateTransform with a CodeExecutor-backed adapter.
  • Inject the renderer via TemplateTransformNode and DifyNodeFactory while keeping default behavior intact.
  • Update TemplateTransform unit tests to mock the renderer output.
  • Tests: make lint, make type-check.

Screenshots

Before After
N/A N/A

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @laipz8200, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the TemplateTransformNode to utilize dependency injection for its template rendering capabilities. The primary goal is to decouple the node from its CodeExecutor dependency, making the component more modular, easier to test, and aligned with modern software design principles. This change introduces a new template renderer abstraction and updates the node factory to manage and inject this dependency.

Highlights

  • Dependency Injection for TemplateTransformNode: The TemplateTransformNode now supports constructor-based dependency injection for its template rendering logic, specifically for the CodeExecutor dependency.
  • New Template Renderer Abstraction: A new Jinja2TemplateRenderer protocol and its concrete implementation, CodeExecutorJinja2TemplateRenderer, have been introduced to abstract the template rendering process.
  • Node Factory Integration: The NodeFactory has been updated to instantiate and inject the CodeExecutorJinja2TemplateRenderer into TemplateTransformNode instances upon creation, ensuring proper dependency management.
  • Improved Testability and Modularity: By introducing dependency injection, the TemplateTransformNode is now more modular and testable, as its rendering mechanism can be easily mocked or swapped.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@laipz8200 laipz8200 changed the title Node DI: TemplateTransform (vibe-kanban) refactor(workflow): add Jinja2 renderer abstraction for template transform Jan 4, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the template transformation node by introducing a Jinja2TemplateRenderer protocol and its CodeExecutorJinja2TemplateRenderer implementation. This change abstracts the template rendering logic, allowing TemplateTransformNode and NodeFactory to use dependency injection for the renderer, thereby enhancing modularity and testability. The TemplateTransformNode now utilizes this new renderer, catching TemplateRenderError instead of CodeExecutionError, and its unit tests have been updated to reflect these architectural changes, including patching the new renderer's method and adjusting mock return values. A review comment suggests explicitly inheriting CodeExecutorJinja2TemplateRenderer from Jinja2TemplateRenderer for improved clarity and static type checking.

…de and threaded it through DifyNodeFactory so TemplateTransform nodes receive the dependency by default, keeping behavior unchanged unless an override is provided. Changes are in `api/core/workflow/nodes/template_transform/template_transform_node.py` and `api/core/workflow/nodes/node_factory.py`.

**Commits**
- chore(workflow): identify TemplateTransform dependency on CodeExecutor
- feat(workflow): add CodeExecutor constructor injection to TemplateTransformNode (defaulting to current behavior)
- feat(workflow): inject CodeExecutor from DifyNodeFactory when creating TemplateTransform nodes

**Tests**
- Not run (not requested)

Next step: run `make lint` and `make type-check` if you want to validate the backend checks.
…Transform to use it, keeping CodeExecutor as the default adapter while preserving current behavior. Updates are in `api/core/workflow/nodes/template_transform/template_renderer.py`, `api/core/workflow/nodes/template_transform/template_transform_node.py`, `api/core/workflow/nodes/node_factory.py`, and `api/tests/unit_tests/core/workflow/nodes/template_transform/template_transform_node_spec.py`.

Commit-style summary:
- feat(template-transform): add Jinja2 template renderer abstraction with CodeExecutor adapter
- refactor(template-transform): use renderer in node/factory and update unit test patches

Tests not run (not requested).
…ode creation to return TemplateTransformNode directly for template-transform nodes in `api/core/workflow/nodes/node_factory.py`.

Commit-style summary:
- refactor(template-transform): derive TemplateRenderError from ValueError
- refactor(node-factory): instantiate TemplateTransformNode directly with injected renderer

Tests not run (not requested).
…ts/core/workflow/nodes/template_transform/template_transform_node_spec.py`)

chore(type-check): ran `make type-check` (basedpyright clean, 0 errors)

No errors reported.
@laipz8200 laipz8200 force-pushed the 43e4-node-di-template branch from 531c674 to 45dd2e3 Compare January 4, 2026 16:22
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@laipz8200 laipz8200 marked this pull request as ready for review January 4, 2026 16:34
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🌊 feat:workflow Workflow related stuff. labels Jan 4, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 5, 2026
@crazywoola crazywoola merged commit 95edbad into main Jan 5, 2026
15 checks passed
@crazywoola crazywoola deleted the 43e4-node-di-template branch January 5, 2026 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌊 feat:workflow Workflow related stuff. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants