Changes strlen comparison to 0 to direct empty string compare (#59686)

Co-authored-by: Lucas Michot <lucas@zaiple.com>

Author: lucasmichot

rector.php

@@ -2,6 +2,7 @@
 
 declare(strict_types=1);
 
+use Rector\CodeQuality\Rector\Identical\StrlenZeroToIdenticalEmptyStringRector;
 use Rector\CodingStyle\Rector\ArrowFunction\ArrowFunctionDelegatingCallToFirstClassCallableRector;
 use Rector\CodingStyle\Rector\Closure\ClosureDelegatingCallToFirstClassCallableRector;
 use Rector\CodingStyle\Rector\FuncCall\ClosureFromCallableToFirstClassCallableRector;
@@ -81,6 +82,9 @@
         ThisCallOnStaticMethodToStaticCallRector::class,
         'tests/Foundation/fixtures/bad-syntax-strategy.php',
     ])
+    ->withRules([
+        StrlenZeroToIdenticalEmptyStringRector::class,
+    ])
     ->withPreparedSets(
         deadCode: false,
         codeQuality: false,

src/Illuminate/Console/Concerns/ConfiguresPrompts.php

@@ -141,7 +141,7 @@ protected function promptUntilValid($prompt, $required, $validate)
 
             $error = is_callable($validate) ? $validate($result) : $this->validatePrompt($result, $validate);
 
-            if (is_string($error) && strlen($error) > 0) {
+            if (is_string($error) && $error !== '') {
                 $this->components->error($error);
 
                 if ($this->laravel->runningUnitTests()) {

src/Illuminate/Database/Eloquent/Concerns/TransformsToResource.php

@@ -71,7 +71,7 @@ public static function guessResourceName(): array
         $potentialResource = sprintf(
             '%s\\Http\\Resources\\%s%s',
             Str::before($modelClass, '\\Models'),
-            strlen($relativeNamespace) > 0 ? $relativeNamespace.'\\' : '',
+            (string) $relativeNamespace !== '' ? $relativeNamespace.'\\' : '',
             class_basename($modelClass)
         );
 

src/Illuminate/Database/Schema/SqliteSchemaState.php

@@ -46,7 +46,7 @@ protected function appendMigrationData(string $path)
         ]));
 
         $migrations = (new Collection(preg_split("/\r\n|\n|\r/", $process->getOutput())))
-            ->filter(fn ($line) => preg_match('/^\s*(--|INSERT\s)/iu', $line) === 1 && strlen($line) > 0)
+            ->filter(fn ($line) => preg_match('/^\s*(--|INSERT\s)/iu', $line) === 1 && $line !== '')
             ->all();
 
         $this->files->append($path, implode(PHP_EOL, $migrations).PHP_EOL);

src/Illuminate/Hashing/AbstractHasher.php

@@ -25,7 +25,7 @@ public function info($hashedValue)
      */
     public function check(#[\SensitiveParameter] $value, $hashedValue, array $options = [])
     {
-        if (is_null($hashedValue) || strlen($hashedValue) === 0) {
+        if (is_null($hashedValue) || (string) $hashedValue === '') {
             return false;
         }
 

src/Illuminate/Hashing/Argon2IdHasher.php

@@ -18,7 +18,7 @@ class Argon2IdHasher extends ArgonHasher
      */
     public function check(#[\SensitiveParameter] $value, $hashedValue, array $options = [])
     {
-        if (is_null($hashedValue) || strlen($hashedValue) === 0) {
+        if (is_null($hashedValue) || (string) $hashedValue === '') {
             return false;
         }
 

src/Illuminate/Hashing/ArgonHasher.php

@@ -95,7 +95,7 @@ protected function algorithm()
      */
     public function check(#[\SensitiveParameter] $value, $hashedValue, array $options = [])
     {
-        if (is_null($hashedValue) || strlen($hashedValue) === 0) {
+        if (is_null($hashedValue) || (string) $hashedValue === '') {
             return false;
         }
 

src/Illuminate/Hashing/BcryptHasher.php

@@ -81,7 +81,7 @@ public function make(#[\SensitiveParameter] $value, array $options = [])
      */
     public function check(#[\SensitiveParameter] $value, $hashedValue, array $options = [])
     {
-        if (is_null($hashedValue) || strlen($hashedValue) === 0) {
+        if (is_null($hashedValue) || (string) $hashedValue === '') {
             return false;
         }
 

src/Illuminate/Process/FakeProcessDescription.php

@@ -99,7 +99,7 @@ public function replaceOutput(string $output)
             ->values()
             ->all();
 
-        if (strlen($output) > 0) {
+        if ($output !== '') {
             $this->output[] = [
                 'type' => 'out',
                 'buffer' => rtrim($output, "\n")."\n",
@@ -122,7 +122,7 @@ public function replaceErrorOutput(string $output)
             ->values()
             ->all();
 
-        if (strlen($output) > 0) {
+        if ($output !== '') {
             $this->output[] = [
                 'type' => 'err',
                 'buffer' => rtrim($output, "\n")."\n",

src/Illuminate/Routing/RouteParameterBinder.php

@@ -89,7 +89,7 @@ protected function matchToKeys(array $matches)
         $parameters = array_intersect_key($matches, array_flip($parameterNames));
 
         return array_filter($parameters, function ($value) {
-            return is_string($value) && strlen($value) > 0;
+            return is_string($value) && $value !== '';
         });
     }