[9.x] Extend eloquent higher order proxy properties#41449
Merged
taylorotwell merged 4 commits intoMar 12, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Pull requests #41096 and #41296 added the ability to negate query conditions, primarily negating closures of conditions or in other words: scopes.
I remembered there was a nice way of changing the
booleanof model scopes fromandtoorusing the HigherOrderBuilderProxy.I decided to add an easy way to add proxied properties and for starters in addition to the
orWheremethod I also added the methodswhereNotandorWhereNotto be proxied.I have also added tests.
This is what is changed in terms of coding and syntactic sugar.
Before you would write:
Now you can use:
I think this is quite nice looking code.