[12.x] Fix QueryException showing wrong connection details for read PDO#58331
Merged
taylorotwell merged 3 commits into12.xfrom Jan 9, 2026
Merged
[12.x] Fix QueryException showing wrong connection details for read PDO#58331taylorotwell merged 3 commits into12.xfrom
taylorotwell merged 3 commits into12.xfrom
Conversation
When using read/write database connections with useReadPdo: true, the QueryException was always showing the write connection details instead of the read connection details. This fix stores the read PDO configuration separately and uses it when building exception details for queries that failed on the read connection.
When using read/write database connections with useReadPdo: true, the QueryException was always showing the write connection details instead of the read connection details. This fix stores the read PDO configuration separately and uses it when building exception details for queries that failed on the read connection.
timacdonald
reviewed
Jan 9, 2026
When using read/write database connections with useReadPdo: true, the QueryException was always showing the write connection details instead of the read connection details. This fix stores the read PDO configuration separately and uses it when building exception details for queries that failed on the read connection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously on this PR we added the connection details to the
QueryException, however, it wasn't getting the correct host for thereadPdo.This PR introduced the
latestReadWriteTypeUsed()which allows us to know which connection was last used.This PR
$readPdoConfigproperty andsetReadPdoConfig()method to store read connection configurationgetConnectionDetails()to return read config whenlatestReadWriteTypeUsed() === 'read'Before
When
DB::connection('mysql')->select('...', useReadPdo: true)failed, exception showed:Host: write.host.example(incorrect)After
Exception correctly shows:
Host: read.host.exampleHow to reproduce
Connection Error
config/database.php:Query Error
config/database.php: