Make \Illuminate\Testing\TestResponse::assertHeader() case insensitive#58383
Merged
taylorotwell merged 1 commit intolaravel:12.xfrom Jan 15, 2026
Merged
Make \Illuminate\Testing\TestResponse::assertHeader() case insensitive#58383taylorotwell merged 1 commit intolaravel:12.xfrom
taylorotwell merged 1 commit intolaravel:12.xfrom
Conversation
I bumped into a PhpUnit error today when asserting the response has the correct header:
```php
$response->assertHeader('content-type', 'text/html; charset=UTF-8');
```
PhpUnit error:
```
Header [content-type] was found, but value [text/html; charset=utf-8] does not match [text/html; charset=UTF-8].
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'text/html; charset=UTF-8'
+'text/html; charset=utf-8'
[..paths omitted..]
```
It might be that `redirect('/some/path')` fairly recently changed from UTF-8 to utf-8 due to HPACK/QPACK normalisation rules. But it broke some of my tests.
In principle these HTTP headers are case-insensitive, so this change to `\Illuminate\Testing\TestResponse::assertHeader()` makes sense.
Let me know if you agree, or you want it fixed in another way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I bumped into a PhpUnit error today when asserting the response has the correct header:
PhpUnit error:
It might be that
redirect('/some/path')fairly recently changed from UTF-8 to utf-8 due to HPACK/QPACK normalisation rules. But it broke some of my tests.In principle these HTTP headers are case-insensitive, so this change to
\Illuminate\Testing\TestResponse::assertHeader()makes sense.Let me know if you agree, or you want it fixed in another way.